-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler/rustc_codegen_ssa/src/mir/place.rs: Remove LLVM bug workaround #100958
Conversation
r? @TaKO8Ki (rust-highfive has picked a reviewer for you, use r? to override) |
This memset was inserted as a workaround to Rust issue rust-lang#34427, which was an LLVM bug that apparently no longer manifests.
79975ab
to
12a9914
Compare
Cc @nikic |
FWIW, I've verified that on an |
Would you be able to try a 32-bit ARM toolchain as well? |
Unfortunately I won't have access to an arm (not aarch64) machine in the immediate future. Worst case scenario it'll be tested on an arm machine before merge right? |
We don't have a 32-bit arm machine in CI, but we do test |
I found a Fedora community machine to try |
@bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (4f9898a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
This memset was inserted as a workaround to Rust issue #34427, which was
an LLVM bug that apparently no longer manifests.