Add more // unit-tests to MIR opt tests
#100086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? rust-lang/mir-opt |
|
☔ The latest upstream changes (presumably #100087) made this pull request unmergeable. Please resolve the merge conflicts. |
wesleywiser
approved these changes
Aug 4, 2022
|
Thanks @JakobDegen! @bors r+ |
|
📌 Commit 10087406345124b1c10bcadd89aae0639314bfc2 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
Oh, wait. There's a merge conflict. @bors r- r=me with that resolved |
bors
added
S-waiting-on-author
JakobDegen
force-pushed
the
better-tests
branch
from
1008740
to
ac75863
Compare
|
@rustbot ready Nothing interesting changed, no bors perms though @wesleywiser |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 9, 2022
…iser Add more `// unit-test`s to MIR opt tests I only changed things which are hopefully completely uninteresting. I plan to submit more PRs that cover more files, but those cases will need some more complicated (and hence possibly controversial) changes, so I'll try and submit those in reasonably sized batches. r? rust-lang/wg-mir-opt
bors
added
S-waiting-on-author
|
✌️ @JakobDegen can now approve this pull request |
JakobDegen
force-pushed
the
better-tests
branch
from
ac75863
to
7a1bfc0
Compare
|
Thanks, was able to reproduce and fix the failure locally, hopefully bors agrees. Wonder what it would take to make GHA run these... @bors r=wesleyweiser |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 10, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#99573 (Stabilize backtrace) - rust-lang#100069 (Add error if link_ordinal used with unsupported link kind) - rust-lang#100086 (Add more `// unit-test`s to MIR opt tests) - rust-lang#100332 (Rename integer log* methods to ilog*) - rust-lang#100334 (Suggest a missing semicolon before an array) - rust-lang#100340 (Iterate generics_def_id_map in reverse order to fix P-critical issue) - rust-lang#100345 (docs: remove repetition in `is_numeric` function docs) - rust-lang#100352 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only changed things which are hopefully completely uninteresting. I plan to submit more PRs that cover more files, but those cases will need some more complicated (and hence possibly controversial) changes, so I'll try and submit those in reasonably sized batches.
r? rust-lang/wg-mir-opt