Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify what static means #9962

Closed
thestinger opened this issue Oct 19, 2013 · 5 comments
Closed

clarify what static means #9962

thestinger opened this issue Oct 19, 2013 · 5 comments
Milestone
1.0

Comments

@thestinger
Copy link
Contributor

Are these compile-time constants? If they are, we need to drop support for foreign constants. If they aren't, this code is going to need a rewrite because it makes the assumption that any static is a known constant.

See #9866 and #9909 for some of the issues caused by this being unspecified and not handled correctly.
@alexcrichton
Copy link
Member

Nominating.

@catamorphism
Copy link
Contributor

1.0 backcompat

@LeoTestard LeoTestard mentioned this issue Nov 12, 2013
Closed
@brson
Copy link
Contributor

brson commented Jun 9, 2014

Is there anything to do here beyond significant addresses (#8958)?

@brson
Copy link
Contributor

brson commented Jun 9, 2014

Nominating for closing. This doesn't appear actionable.

@pnkfelix
Copy link
Member

Closing as nonactionable beyond #8958.

flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 17, 2022
@bors
Auto merge of rust-lang#9962 - mdgaziur:master, r=dswij
56d5657 
Fix rust-lang#9958

This PR fixes rust-lang#9958. In order to fix the issue, the lint will now peel reference operators and enclose the expression with parentheses when necessary.

changelog: [`comparison_to_empty`]: Peel deref operators in suggestions when necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
5 participants
@alexcrichton @brson @pnkfelix @catamorphism @thestinger