-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICE using impl ?Sized
in return position
#97226
Comments
This regressed between 1.60 -> 1.61 from an error to an ICE.
|
searched nightlies: from nightly-2022-01-15 to nightly-2022-05-22 bisected with cargo-bisect-rustc v0.6.2Host triple: x86_64-unknown-linux-gnu cargo bisect-rustc --start=2022-01-15 --end=2022-05-22 --regress=ice |
don't do `Sized` and other return type checks on RPIT's real type Fixes an ICE where we're doing `Sized` check against the RPIT's real type, instead of against the opaque type. This differs from what we're doing in MIR typeck, which causes ICE rust-lang#97226. This regressed in rust-lang#96516 -- this adjusts that fix to be a bit more conservative. That PR was backported and thus the ICE is also present in stable. Not sure if it's worth to beta and/or stable backport, probably not the latter but I could believe the former. r? `@oli-obk` cc: another attempt to fix this ICE rust-lang#97413. I believe this PR addresses the root cause.
Fixed by #97431 |
This is a regression on stable and beta, reopening until backport is settled. |
don't do `Sized` and other return type checks on RPIT's real type Fixes an ICE where we're doing `Sized` check against the RPIT's real type, instead of against the opaque type. This differs from what we're doing in MIR typeck, which causes ICE rust-lang#97226. This regressed in rust-lang#96516 -- this adjusts that fix to be a bit more conservative. That PR was backported and thus the ICE is also present in stable. Not sure if it's worth to beta and/or stable backport, probably not the latter but I could believe the former. r? `@oli-obk` cc: another attempt to fix this ICE rust-lang#97413. I believe this PR addresses the root cause.
Code
Playground
Meta
Error occurs on
Stable 1.61.0
Beta 1.62.0-beta.2
Nightly 2022-05-19
Error output
Backtrace
The text was updated successfully, but these errors were encountered: