Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.57 release notes are missing changes to dead code analysis #93894

Closed
nsunderland1 opened this issue Feb 11, 2022 · 6 comments · Fixed by #93928
Closed

1.57 release notes are missing changes to dead code analysis #93894

nsunderland1 opened this issue Feb 11, 2022 · 6 comments · Fixed by #93928
Assignees
@nsunderland1
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@nsunderland1
Copy link
Contributor

nsunderland1 commented Feb 11, 2022 •
edited by rustbot
Loading

#85200 landed in 1.57, causing derived Debug and Clone implementations to be ignored during dead code analysis. The release notes for 1.57 don't mention this change anywhere.

There's discussion in the original PR about including it in the release notes, but looks like nobody got around to it.
@nsunderland1
Copy link
Contributor Author

nsunderland1 commented Feb 11, 2022 •
edited
Loading

I think this is also worth a mention in the compatibility notes for 1.57, given that it can break builds where deny(dead_code) is set.

@nsunderland1
Copy link
Contributor Author

@rustbot label +D-incorrect +D-invalid-suggestion

@rustbot rustbot added D-incorrect Diagnostics: A diagnostic that is giving misleading or incorrect information. D-invalid-suggestion Diagnostics: A structured suggestion resulting in incorrect code. labels Feb 12, 2022
@nsunderland1
Copy link
Contributor Author

@rustbot label -D-incorrect -D-invalid-suggestion

@rustbot rustbot removed D-incorrect Diagnostics: A diagnostic that is giving misleading or incorrect information. D-invalid-suggestion Diagnostics: A structured suggestion resulting in incorrect code. labels Feb 12, 2022
@nsunderland1
Copy link
Contributor Author

My bad there, had two different issues open.

@Mark-Simulacrum
Copy link
Member

I'd be happy to approve a PR adding a line to the release notes about this.

@Mark-Simulacrum Mark-Simulacrum added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Feb 12, 2022
@nsunderland1
Copy link
Contributor Author

@rustbot claim

@nsunderland1 nsunderland1 mentioned this issue Feb 12, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 12, 2022
@matthiaskrgr
Rollup merge of rust-lang#93928 - nsunderland1:master, r=Mark-Simulacrum
7d02faa 
Add missing release notes for rust-lang#85200

Fixes rust-lang#93894
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 12, 2022
@matthiaskrgr
Rollup merge of rust-lang#93928 - nsunderland1:master, r=Mark-Simulacrum
7e3fb2b 
Add missing release notes for rust-lang#85200

Fixes rust-lang#93894
@bors bors closed this as completed in 0e3ecd2 Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsunderland1 nsunderland1

Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing release notes for #85200 nsunderland1/rust
3 participants
@Mark-Simulacrum @nsunderland1 @rustbot