Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark functions returning ! as noreturn #9317

Closed
thestinger opened this issue Sep 19, 2013 · 0 comments · Fixed by #9491
Closed

mark functions returning ! as noreturn #9317

thestinger opened this issue Sep 19, 2013 · 0 comments · Fixed by #9491
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@thestinger
Copy link
Contributor

nounwind is separate, so I think this would be perfectly safe but likely not very useful
@thestinger thestinger mentioned this issue Sep 25, 2013
Merged
bors added a commit that referenced this issue Sep 25, 2013
@bors
auto merge of #9491 : thestinger/rust/noreturn, r=huonw
5375cf8 
Closes #9317
Jarcho pushed a commit to Jarcho/rust that referenced this issue Aug 29, 2022
@bors
Auto merge of rust-lang#9329 - xphoniex:fix-rust-lang#9317, r=flip1995
8c9040c 
Skip `unnecessary_to_owned` when `t != t.to_string()`

Fixes rust-lang#9317

changelog: [`unnecessary_to_owned`]: none
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 9, 2022
Fix unnecessary_to_owned false positive
750a2d5 
Fixes rust-lang#9351.

Note that this commit reworks that fix for rust-lang#9317. The change
is to check that the type implements `AsRef<str>` before regarding
`to_string` as an equivalent of `to_owned`. This was suggested
by Jarcho in the rust-lang#9317 issue comments.

The benefit of this is that it moves some complexity out of
`check_other_call_arg` and simplifies the module as a whole.
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 9, 2022
@bors
Auto merge of rust-lang#9424 - mikerite:fix-9351-4, r=xFrednet
46b7cb6 
Fix `unnecessary_to_owned` false positive

Fixes rust-lang#9351.

Note that this commit reworks that fix for rust-lang#9317. The change
is to check that the type implements `AsRef<str>` before regarding
`to_string` as an equivalent of `to_owned`. This was suggested
by Jarcho in the rust-lang#9317 issue comments.

The benefit of this is that it moves some complexity out of
`check_other_call_arg` and simplifies the module as a whole.

changelog: FP: [`unnecessary_to_owned`]: No longer lints, if type change would cause errors in the caller function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add noreturn attribute to functions returning !
1 participant
@thestinger