Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Clippy changes #92938

Closed
Alexendoo opened this issue Jan 15, 2022 · 3 comments
Closed

Backport Clippy changes #92938

Alexendoo opened this issue Jan 15, 2022 · 3 comments
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@Alexendoo
Copy link
Member

commit: rust-lang/rust-clippy@5d63a28, context: rust-lang/rust-clippy#8045
@Alexendoo Alexendoo added T-release Relevant to the release subteam, which will review and decide on the PR/issue. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Jan 15, 2022
@flip1995 flip1995 mentioned this issue Jan 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 18, 2022
@bors
Auto merge of rust-lang#93001 - flip1995:clippyup, r=Manishearth
e4ff903 
Out of cycle Clippy update

I want to do an out-of-cycle sync for rust-lang/rust-clippy#8295, and possibly backport this to stable together with rust-lang#92938. If this doesn't get backported to stable, then I at least want to backport it to beta.

r? `@Manishearth`
@flip1995
Copy link
Member

Besides 5d63a28, we'd also like to backport cb384ff, which addresses a bug with our useless_format lint when it comes to implicit named arguments. This was fixed in rust-lang/rust-clippy#8295 and synced to rustc in #93001. That will also need a beta backport.

@Alexendoo Alexendoo changed the title Backport Clippy non_send_fields_in_send_ty change Backport Clippy changes Jan 18, 2022
@Alexendoo Alexendoo added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 18, 2022
@pietroalbini pietroalbini mentioned this issue Jan 19, 2022
Merged
@pietroalbini pietroalbini added stable-accepted Accepted for backporting to the compiler in the stable channel. and removed stable-nominated Nominated for backporting to the compiler in the stable channel. labels Jan 19, 2022
bors added a commit to rust-lang/rust-clippy that referenced this issue Jan 27, 2022
@bors
Auto merge of #93001 - flip1995:clippyup, r=Manishearth
7a2cabb 
Out of cycle Clippy update

I want to do an out-of-cycle sync for #8295, and possibly backport this to stable together with rust-lang/rust#92938. If this doesn't get backported to stable, then I at least want to backport it to beta.

r? `@Manishearth`
@flip1995 flip1995 mentioned this issue Jan 27, 2022
Merged
@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 27, 2022
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 27, 2022
@bors
Auto merge of rust-lang#93377 - flip1995:beta-backport, r=Mark-Simula…
28c8a34 
…crum

[beta] Clippy: Handle implicit named arguments in `useless_format`

Closes rust-lang#92938

This backports a Clippy fix to beta, that was already backported for 1.58.1 in rust-lang#93110
@ehuss
Copy link
Contributor

ehuss commented Feb 14, 2022

I think this can be closed with #93377 merged? For some reason, GitHub didn't auto-close this.

@Mark-Simulacrum
Copy link
Member

Seems right.

@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ehuss @Alexendoo @pietroalbini @Mark-Simulacrum @flip1995