Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Read and Write show up as notable traits on &mut [u16] #91347

Closed
jsha opened this issue Nov 29, 2021 · 1 comment · Fixed by #91366
Closed

rustdoc: Read and Write show up as notable traits on &mut [u16] #91347

jsha opened this issue Nov 29, 2021 · 1 comment · Fixed by #91366
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Nov 29, 2021

https://rustdoc.crud.net/jsha/fewer-colors/std/primitive.char.html#method.encode_utf16

image
@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Nov 29, 2021
@notriddle notriddle mentioned this issue Nov 29, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 30, 2021
@matthiaskrgr
Rollup merge of rust-lang#91366 - notriddle:notriddle/only-show-notab…
2b8259a 
…le-if-types-are-the-same, r=GuillaumeGomez

Only show notable traits if both types are the same

Checking only their DefId doesn't work because all slices have the same
fake DefId.

Fixes rust-lang#91347
@bors bors closed this as completed in 85ba6c7 Dec 1, 2021
@camelid
Copy link
Member

camelid commented Dec 10, 2021

@notriddle there are several issues which I think are duplicates of this and thus fixed by your change, but I'm not certain. Can you let me know if these can be closed?

@notriddle notriddle mentioned this issue Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only show notable traits if both types are the same notriddle/rust
2 participants
@jsha @camelid