Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Styling regressions from stable to beta #87072

Closed
camelid opened this issue Jul 12, 2021 · 3 comments · Fixed by #87125
Closed

rustdoc: Styling regressions from stable to beta #87072

camelid opened this issue Jul 12, 2021 · 3 comments · Fixed by #87125
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone
1.54.0

Comments

@camelid
Copy link
Member

camelid commented Jul 12, 2021 •
edited
Loading

Regression 1

Ayu-only. The summary in the search results is now blue, when it used to be white.

beta (incorrect)

image

stable (correct)

image

Regression 2

Ayu-only. The color of impls in Ayu has changed from white to yellow. This may be intentional, but it looked off when I saw it. Note that this happens for all impls, not just foreign impls.

beta (incorrect)

image

stable (correct)

image

Regression 3

All themes. Certain auto-trait, foreign, unconditional impls have underlines.

beta (incorrect)

image

stable (correct)

image

Regression 4

All themes. The phrase (keyword) next to match in the search results is now red in addition to match itself being red, whereas (keyword) used to be gray.

beta (incorrect)

image

stable (correct)

image

Meta

All of the regressions seem to have occurred in beta (1.54.0).
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. C-bug Category: This is a bug. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jul 12, 2021
@camelid camelid added this to the 1.54.0 milestone Jul 12, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 12, 2021
@GuillaumeGomez
Copy link
Member

Regression 3 is fixed in #87035.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 12, 2021 •
edited
Loading

Sending a fix for the three others.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 12, 2021
Merged
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 12, 2021 •
edited
Loading

Regressions 1 and 4 are fixed in #87085.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 13, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87085 - GuillaumeGomez:search-result-colors…
1d8d084 
…, r=notriddle

Search result colors

Part of  rust-lang#87072 (fixes the first and fourth regressions and add tests to prevent it from happening again).

cc `@Nemo157`

r? `@camelid`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 13, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87085 - GuillaumeGomez:search-result-colors…
b242ff7 
…, r=notriddle

Search result colors

Part of  rust-lang#87072 (fixes the first and fourth regressions and add tests to prevent it from happening again).

cc ``@Nemo157``

r? ``@camelid``
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jul 13, 2021
@JohnTitor
Rollup merge of rust-lang#87085 - GuillaumeGomez:search-result-colors…
baf23b8 
…, r=notriddle

Search result colors

Part of  rust-lang#87072 (fixes the first and fourth regressions and add tests to prevent it from happening again).

cc ```@Nemo157```

r? ```@camelid```
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jul 14, 2021
@JohnTitor
Rollup merge of rust-lang#87085 - GuillaumeGomez:search-result-colors…
fc488d4 
…, r=notriddle

Search result colors

Part of  rust-lang#87072 (fixes the first and fourth regressions and add tests to prevent it from happening again).

cc ````@Nemo157````

r? ````@camelid````
@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 14, 2021
Merged
@bors bors closed this as completed in e0d72d0 Jul 14, 2021
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging a pull request may close this issue.

Fix Ayu theme <code> color GuillaumeGomez/rust
4 participants
@GuillaumeGomez @apiraino @camelid @rustbot