Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#83772 #85824

Closed
rust-highfive opened this issue May 30, 2021 · 1 comment · Fixed by rust-lang/rls#1738
Closed

rls no longer builds after rust-lang/rust#83772 #85824

rust-highfive opened this issue May 30, 2021 · 1 comment · Fixed by rust-lang/rls#1738
Assignees
@jhpratt
Labels
C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

rust-highfive commented May 30, 2021 •
edited by rustbot
Loading

Hello, this is your friendly neighborhood mergebot.
After merging PR #83772, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @jhpratt, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-rls C-bug Category: This is a bug. labels May 30, 2021
@jhpratt
Copy link
Member

jhpratt commented May 30, 2021

Happy to handle the fallout. Should be minimal so long as it's not a third-party crate.

@rustbot claim

@rustbot rustbot assigned jhpratt and unassigned Xanewok May 30, 2021
@jhpratt jhpratt mentioned this issue May 30, 2021
Merged
bors added a commit to rust-lang/rls that referenced this issue May 30, 2021
@bors
Auto merge of #1738 - jhpratt:update-step-trait, r=Xanewok
12a5fd2 
Update `Step` trait implementation

Closes rust-lang/rust#85824

This replaces the `unsafe impl Step` with `impl Step` and `unsafe impl TrustedStep`. This is the only location of the `Step` trait in this repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhpratt jhpratt

Labels
C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Step trait implementation
3 participants
@Xanewok @jhpratt @rust-highfive