You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
giltho opened this issue
May 20, 2021
· 3 comments
· Fixed by #95281
Assignees
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.htmlC-bugCategory: This is a bug.
It feels like this shouldn't be an issue but I don't really know where to post it otherwise.. The documentation of eval_place in the MIR InterpCx says that there is a more efficient solution when the place is access for read called eval_place_for_read, but the latter does not exist anywhere.
I'm guessing it should be referring to eval_place_to_op, but I am not entirely sure. Also as a side question, I'd be curious to know why it is slower to access a place for write than it is for read.
I'm going to spend a bit of time reading that part of the code, if I ever find other tiny things like that, where should I report it ? It feels like this could be a small discussion in a chat followed by a tiny PR rather than an issue.
Thank you !
The text was updated successfully, but these errors were encountered:
Depending how easy a PR it is and whether you're reasonably confident in your deduction, you could also just make a PR changing it and the reviewer will confirm that the update is accurate.
JohnTitor
added
A-MIR
Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html
C-bug
Category: This is a bug.
A-docs
Area: Documentation for any part of the project, including the compiler, standard library, and tools
labels
Jun 10, 2021
I'm going to spend a bit of time reading that part of the code, if I ever find other tiny things like that, where should I report it ? It feels like this could be a small discussion in a chat followed by a tiny PR rather than an issue.
Issues like this are welcome, as are small PRs. :)
Fix inaccurate function name in `rustc_const_eval` docs
Looks to me like this fixesrust-lang#85513. I had trouble making a intra-docs link to `eval_place_to_op` work, though...
Fix inaccurate function name in `rustc_const_eval` docs
Looks to me like this fixesrust-lang#85513. I had trouble making a intra-docs link to `eval_place_to_op` work, though...
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.htmlC-bugCategory: This is a bug.
Hello,
It feels like this shouldn't be an issue but I don't really know where to post it otherwise..
The documentation of
eval_place
in the MIRInterpCx
says that there is a more efficient solution when the place is access for read calledeval_place_for_read
, but the latter does not exist anywhere.I'm guessing it should be referring to
eval_place_to_op
, but I am not entirely sure. Also as a side question, I'd be curious to know why it is slower to access a place for write than it is for read.I'm going to spend a bit of time reading that part of the code, if I ever find other tiny things like that, where should I report it ? It feels like this could be a small discussion in a chat followed by a tiny PR rather than an issue.
Thank you !
The text was updated successfully, but these errors were encountered: