-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc.rust-lang.org/nightly/nightly-rustc
is down
#83914
Comments
Hm, I wonder if this is a similar bug to the one fixed due to link check failure during the bootstrap bump. |
FYI, |
Yeah, almost certainly the bootstrap bump. cc @ehuss (just a heads up, I plan to submit a patch soon, though haven't written it yet) |
My guess without too much investigation is that the symlink_dir_force which intends to share the compiler-doc directory between rustdoc and rustc docs is ending up clobbered. I likely won't get around to a fix tonight but may be able to do so tomorrow, we'll see how much time I have. |
I'm also happy to revert the change on beta, if you want, so there isn't a rush to fix things. |
Yeah, I think we should do that - there's enough stuff broken in rustbuild that's not really of the too unusual kind (well, really just two cases, but they seem fairly typical). I'd rather we drop it from beta and either pursue resource-suffix as suggested by @jyn514 or at least tackle the bugs in rustbuild on a less urgent timescale before relanding. (Ideally we should figure out what people should do; rustbuild's approach to just building twice seems pretty... suboptimal; I imagine that the fix for this newly found bug will end up similar if I do it quickly). |
OK, I have posted rust-lang/cargo#9332. I'll push through the changes, though it may take at least a few days to get beta updated and then bump the version. |
Yeah. I think I'm not sure there's as easy a fix in this case (unlike the simple add of a double core build), as the clobbering occurs over two different steps I believe. So I think we'll wait for that patch to land and bump beta. (We could also temporarily remove, say, rustdoc or rustc docs - but that doesn't seem like a real benefit). |
beta: revert #8640 - rustdoc versioning checks #8640 has been causing some problems with rustbuild (see rust-lang/rust#83914 and rust-lang/rust#83530 (comment)). In order to give more time to figure out a solution, this reverts the change on beta. Will need to take some time to figure out what to do on master. Also cherry picked the following to get tests passing: * #9316 — Fix semver docs for 1.51. * #9307 — tests: Tolerate "exit status" in error messages
Thanks for the speedy fix! The docs are back online now (because it's a bit after midnight UTC). I'm glad they're back :) |
I think it was working yesterday, but https://doc.rust-lang.org/nightly/nightly-rustc/ is giving a "Not Found" response for me. https://doc.rust-lang.org/beta/nightly-rustc/ works fine, however.
The text was updated successfully, but these errors were encountered: