Rustdoc ICE "Unable to fulfill trait" #80233
Assignees
Labels
A-associated-items
Area: Associated items (types, constants & functions)
A-trait-system
Area: Trait system
C-bug
Category: This is a bug.
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
orangeturtle739
added
C-bug
|
might be a duplicate of #79466 |
|
I think there are important differences: this code doesn't use feature gates, and it successfully builds, so rustdoc should be expected to succeed instead of erroring or ICE, and the rationale for prioritizing that low (that the input is invalid) doesn't apply. |
jyn514
added
the
T-rustdoc
|
MCVE (although it panics in a slightly different place): pub trait Trait2 {
type Type2;
}
pub trait Trait3 {
type Type3;
}
pub struct Question {
pub ins: <<usize as Trait3>::Type3 as Trait2>::Type2,
} |
|
Oh interesting my MCVE is not correct - that panics because the impls are missing: If I add those impls, suddenly rustdoc works: impl Trait3 for usize {
type Type3 = isize;
}
impl Trait2 for isize {
type Type2 = i32;
} |
|
In fact there are some programs rustdoc accepts that rustc doesn't: #![crate_type = "lib"]
pub trait Trait1 {}
pub trait Trait2 {
type Type2;
}
pub trait Trait3 {
type Type3;
}
/*
impl<T: Trait1> Trait2 for Struct1<T> {
type Type2 = Struct1<T>;
}
*/
impl<I: Trait2> Trait2 for Vec<I> {
type Type2 = Vec<I::Type2>;
}
impl<T: Trait1> Trait3 for T {
type Type3 = Struct1<T>;
}
impl<T: Trait3> Trait3 for Vec<T> {
type Type3 = Vec<T::Type3>;
}
pub struct Struct1<T: Trait1> {
pub ty: T,
}
pub struct Question<T: Trait1> {
pub ins: <<Vec<T> as Trait3>::Type3 as Trait2>::Type2,
} |
|
Slightly smaller repro: #![crate_type = "lib"]
pub trait Trait1 {}
pub trait Trait2 {
type Type2;
}
pub trait Trait3 {
type Type3;
}
impl Trait2 for Struct1 {
type Type2 = Struct1;
}
impl<I: Trait2> Trait2 for Vec<I> {
type Type2 = Vec<I::Type2>;
}
impl<T: Trait1> Trait3 for T {
type Type3 = Struct1;
}
impl<T: Trait3> Trait3 for Vec<T> {
type Type3 = Vec<T::Type3>;
}
pub struct Struct1 {}
pub struct Question<T: Trait1> {
pub ins: <<Vec<T> as Trait3>::Type3 as Trait2>::Type2,
} |
jyn514
added
A-associated-items
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this issue
Jan 15, 2021
…=estebank Don't try to add nested predicate to Rustdoc auto-trait `ParamEnv` Fixes rust-lang#80233 We already have logic in `evaluate_predicates` that tries to add unimplemented predicates to our `ParamEnv`. Trying to add a predicate that already holds can lead to errors later on, since projection will prefer trait candidates from the `ParamEnv` to predicates from an impl.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this issue
Jan 15, 2021
…=estebank Don't try to add nested predicate to Rustdoc auto-trait `ParamEnv` Fixes rust-lang#80233 We already have logic in `evaluate_predicates` that tries to add unimplemented predicates to our `ParamEnv`. Trying to add a predicate that already holds can lead to errors later on, since projection will prefer trait candidates from the `ParamEnv` to predicates from an impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This bug occurs with
cargo doc.cargo buildworks fine.Code
Meta
rustc --version --verbose:Error output
Backtrace
The text was updated successfully, but these errors were encountered: