Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.py --json-output suppresses CompilerArtifact messages #73209

Closed
RalfJung opened this issue Jun 10, 2020 · 2 comments · Fixed by #73219
Closed

x.py --json-output suppresses CompilerArtifact messages #73209

RalfJung opened this issue Jun 10, 2020 · 2 comments · Fixed by #73219
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@RalfJung
Copy link
Member

When using x.py --json-output, I would expect JSON output to be basically the same as standard cargo. However, that does not seem to be the case: an analysis of rust-lang/rust-analyzer#4827 by @bjorn3 revealed that CompilerArtifact are not propagated properly.

Cc @Mark-Simulacrum
@RalfJung RalfJung mentioned this issue Jun 10, 2020
Closed
@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Jun 10, 2020
@Mark-Simulacrum
Copy link
Member

Problem is here: https://github.com/rust-lang/rust/blob/master/src/bootstrap/compile.rs#L985-L989

Those lines should probably be modified such that we unconditionally print the received line if the --json-output flag is passed?

@bjorn3
Copy link
Member

bjorn3 commented Jun 10, 2020

Yes

@RalfJung RalfJung mentioned this issue Jun 10, 2020
Merged
RalfJung added a commit to RalfJung/rust that referenced this issue Jun 11, 2020
@RalfJung
Rollup merge of rust-lang#73219 - RalfJung:cargo-json, r=Mark-Simulacrum
ef5de43 
x.py: with --json-output, forward cargo's JSON

Fixes rust-lang#73209

r? @Mark-Simulacrum
@bors bors closed this as completed in ba0a8d2 Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

x.py: with --json-output, forward cargo's JSON RalfJung/rust
4 participants
@RalfJung @jonas-schievink @Mark-Simulacrum @bjorn3