Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#69659 #72231

Closed
rust-highfive opened this issue May 15, 2020 · 2 comments · Fixed by #72671
Closed

rls no longer builds after rust-lang/rust#69659 #72231

rust-highfive opened this issue May 15, 2020 · 2 comments · Fixed by #72671
Assignees
@Xanewok
Labels
C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #69659, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @CAD97, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.
@CAD97
Copy link
Contributor

CAD97 commented May 15, 2020

rls-span uses Step directly, so needs to be updated.

@imogenkinsman imogenkinsman mentioned this issue May 18, 2020
Open
@Elinvynia Elinvynia added A-rls C-bug Category: This is a bug. labels May 20, 2020
@Xanewok
Copy link
Member

Xanewok commented May 20, 2020

rls-span uses Step directly, so needs to be updated.

This is fixed in rust-lang/rls@27869c5. What remains is a coordinated bump to rustc-ap-* crates with rustfmt/racer.

@Xanewok Xanewok mentioned this issue May 21, 2020
Closed
@flip1995 flip1995 mentioned this issue May 29, 2020
Merged
@bors bors closed this as completed in 96dd469 May 29, 2020
tesuji pushed a commit to tesuji/rustc that referenced this issue Jun 4, 2020
@bors
Auto merge of rust-lang#72671 - flip1995:clippyup, r=Xanewok
fcc0e8f 
Update Clippy, RLS, and rustfmt

r? @Dylan-DPC

This makes Clippy test-pass again: 3089c3b

Otherwise this includes bugfixes and a few new lints.

Fixes rust-lang#72231
Fixes rust-lang#72232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Clippy, RLS, and rustfmt flip1995/rust
submodules: Update RLS and Rustfmt Xanewok/rust
4 participants
@Xanewok @CAD97 @rust-highfive @Elinvynia