avx512 support regression in 1.43 #71473
Labels
disposition-merge
This issue / PR is in PFCP or FCP with a disposition to merge it.
finished-final-comment-period
The final comment period is finished for this PR / Issue.
regression-from-stable-to-stable
Performance or correctness regression from one stable version to another.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
lu-zero
added a commit
to rust-av/rav1e
that referenced
this issue
Apr 23, 2020
Due some miscommunication upstream disabled all the icelake flags in the current stable release. The issue is tracked in rust-lang/rust#71473
lu-zero
added a commit
to rust-av/rav1e
that referenced
this issue
Apr 23, 2020
Due some miscommunication upstream disabled all the icelake flags in the current stable release. The issue is tracked in rust-lang/rust#71473
|
Note that this worked in 1.42, so this is a stable-to-stable regression. |
|
This basically #68905. We re-stabilized some of the avx512 features that were used by BLAKE3, but it seems that we missed rav1e. |
joshtriplett
added
I-nominated
T-lang
|
@Amanieu Any chance you could prepare a fix? I think this is worth a stable point release. |
lu-zero
added a commit
to rust-av/rav1e
that referenced
this issue
Apr 23, 2020
Due some miscommunication upstream disabled all the icelake flags in the current stable release. The issue is tracked in rust-lang/rust#71473
lu-zero
added a commit
to rust-av/rav1e
that referenced
this issue
Apr 23, 2020
Due some miscommunication upstream disabled all the icelake flags in the current stable release. The issue is tracked in rust-lang/rust#71473
|
Summarizing some discussions in the lang team meeting, regarding CPU feature naming: there are inconsistencies in feature naming between LLVM, GCC, GAS, and the Linux kernel, but we have a mild technical reason to defer to LLVM (doing otherwise requires renaming the feature). So let's defer to LLVM naming of CPU features, which doesn't tend to use underscores. |
joshtriplett
added
regression-from-stable-to-stable
Amanieu
added
T-libs-api
|
In rust-lang/stdarch#849 I stabilized all remaining x86 features for feature detection. @rfcbot fcp merge |
|
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
Why wasn't this caught by the crater runs for 1.43? It builds stuff from github, no? |
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
Hmm yeah there were issues compiling the asm files: |
|
I looks like the assembler is too old and doesn't recognize the AVX-512 instructions |
|
cc @rust-lang/infra We missed a regression on crater because it had an old version of nasm, which caused the |
Hmm yeah that might be it. It seems to run Ubuntu 18.04 LTS which uses nasm 2.13. An update to 20.04 LTS will bring nasm 2.14 and probably fix the issue short term but not long term once rav1e starts requiring newer nasm versions. |
kennytm
added
the
T-infra
lu-zero
added a commit
to xiph/rav1e
that referenced
this issue
Apr 24, 2020
Due some miscommunication upstream disabled all the icelake flags in the current stable release. The issue is tracked in rust-lang/rust#71473
shssoichiro
pushed a commit
to xiph/rav1e
that referenced
this issue
Apr 24, 2020
In order to find regressions like rust-lang/rust#71473 before stable releases.
kennytm
removed
the
T-infra
|
(removing stable-nominated tag, as we nominate PR's for backport, not issues) |
pnkfelix
removed
the
stable-nominated
rfcbot
added
finished-final-comment-period
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 4, 2020
…roalbini [stable] 1.43.1 release * [Updated openssl-src to 1.1.1g for CVE-2020-1967.][71430] * [Fixed the stabilization of AVX-512 features.][71473] * [Fixed `cargo package --list` not working with unpublished dependencies.][cargo/8151] [71430]: rust-lang#71430 [71473]: rust-lang#71473 [cargo/8151]: rust-lang/cargo#8151
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this issue
May 17, 2020
Pkgsrc changes: * None. Upstream changes: Version 1.43.1 (2020-05-07) =========================== * [Updated openssl-src to 1.1.1g for CVE-2020-1967.][71430] * [Fixed the stabilization of AVX-512 features.][71473] * [Fixed `cargo package --list` not working with unpublished dependencies.] [cargo/8151] [71430]: rust-lang/rust#71430 [71473]: rust-lang/rust#71473 [cargo/8151]: rust-lang/cargo#8151
barrbrain
pushed a commit
to barrbrain/rav1e
that referenced
this issue
May 26, 2020
In order to find regressions like rust-lang/rust#71473 before stable releases.
barrbrain
pushed a commit
to xiph/rav1e
that referenced
this issue
May 26, 2020
In order to find regressions like rust-lang/rust#71473 before stable releases.
barrbrain
pushed a commit
to barrbrain/rav1e
that referenced
this issue
May 26, 2020
Due some miscommunication upstream disabled all the icelake flags in the current stable release. The issue is tracked in rust-lang/rust#71473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It was notified on zulip before
The text was updated successfully, but these errors were encountered: