-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc does not verify feature gates #67647
Comments
cc @GuillaumeGomez @rust-lang/rustdoc |
I'd guess this is related to https://github.com/rust-lang/rust/blob/master/src/librustdoc/core.rs#L318 somehow. I'm not entirely sure what rustdoc relies on which would mandate the locking in of the permission to use unstable features, but perhaps @GuillaumeGomez would know? |
Normally, for such things rustdoc relies on rustc internals to do the work. Maybe an option is badly set? |
triage: looks like this should be T-rustdoc's call as to what priority to assign here. Leaving unprioritized and nominated, at least for a week. |
I made the priority medium: it's not a huge bug but the quicker it's fixed, the better it'll be for everyone. |
#67989 should fix this. |
@ollie27 Thanks! I've also gone ahead and nominated it for beta backport as it's probably good to close the stability hole sooner rather than later; it's a trivial patch. |
…meGomez rustdoc: Don't allow `#![feature(...)]` on stable or beta Fixes rust-lang#67647 r? @GuillaumeGomez
This generates documentation with a stable rustdoc today without any warnings.
Interestingly, rustdoc does seem to check that the feature gate is in the crate (i.e.,
#![feature(raw)]
must exist), and will error if a feature gate has been removed (e.g., custom_attribute on nightly).The text was updated successfully, but these errors were encountered: