unused_labels should be reported as warnings #66324
Labels
A-lints
Area: Lints (warnings about flaws in source code) such as unused_mut.
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
Comments
|
Seems reasonable; want to file a PR? cc @rust-lang/lang |
jonas-schievink
added
A-lints
|
Working… |
|
OK, PR #66325 is in the queue. Let me know if I need to do something different. Thanks! |
Centril
added a commit
to Centril/rust
that referenced
this issue
Dec 7, 2019
Change unused_labels from allow to warn Fixes rust-lang#66324, making the unused_labels lint warn instead of allow by default. I'm told @rust-lang/lang will need to review this, and perhaps will want to do a crater run.
Centril
added a commit
to Centril/rust
that referenced
this issue
Dec 8, 2019
Change unused_labels from allow to warn Fixes rust-lang#66324, making the unused_labels lint warn instead of allow by default. I'm told @rust-lang/lang will need to review this, and perhaps will want to do a crater run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A long while back there was Issue #50751 which pointed out that the compiler was not linting for unused break labels. This resulted after a lot of fantastic hard work in PR #50763 which added the
unused_labelslint.At the time, the lint was set to
allowby default. The consensus was that there would need to be a review and a crater run before it was changed towarn. Issue #50751 was closed without this happening, and this is where we stand today.I'd love to see this changed to
warnby default. Any chance that could happen?The text was updated successfully, but these errors were encountered: