Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy-driver no longer builds after rust-lang/rust#65885 #65888

Closed
rust-highfive opened this issue Oct 28, 2019 · 0 comments · Fixed by #65904
Closed

clippy-driver no longer builds after rust-lang/rust#65885 #65888

rust-highfive opened this issue Oct 28, 2019 · 0 comments · Fixed by #65904
Assignees
@oli-obk @Manishearth @yaahc @phansch @mcarton @llogiq @flip1995
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #65885, I observed that the tool clippy-driver no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rust-clippy is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2019
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 28, 2019
@matthiaskrgr
submodules: update clippy from 66df92a to c8e3cfb
f9ac609 
Changes:
````
travis: temporarily disable rustfmt ci check until rust-lang#4742 is resolved
rustup rust-lang#65792
Fix ICE rust-lang#4579
Add regression test for ICE rust-lang#4579
Run update_lints for Unicode lint
Re-add false positive check
Add raw string regression test for useless_format lint
Re-factor useless_format lint
Update Unicode lint tests
[Backported] Rustup to rust-lang#59545
````

Fixes #rust-lang#65888
@matthiaskrgr matthiaskrgr mentioned this issue Oct 28, 2019
Merged
@bors bors closed this as completed in caa1f8d Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

@Manishearth Manishearth

@yaahc yaahc

@phansch phansch

@mcarton mcarton

@llogiq llogiq

@flip1995 flip1995

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update clippy from 66df92ae to c8e3cfbd matthiaskrgr/rust
8 participants
@oli-obk @Manishearth @yaahc @phansch @mcarton @llogiq @rust-highfive @flip1995