Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove await! macro-like syntax support #60610

Closed
cramertj opened this issue May 7, 2019 · 0 comments · Fixed by #62293
Closed

Remove await! macro-like syntax support #60610

cramertj opened this issue May 7, 2019 · 0 comments · Fixed by #62293
Assignees
@cramertj
Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@cramertj
Copy link
Member

cramertj commented May 7, 2019

#60586 moves support for await!(<expr>) syntax under a separate feature gate from async { ... } and .await. Once folks working on nightly have been given time to migrate (~a release cycle or so) we should remove this hack.
@cramertj cramertj added A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. labels May 7, 2019
@cramertj cramertj self-assigned this May 7, 2019
@cramertj cramertj mentioned this issue May 7, 2019
Merged
@Centril Centril added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-lang Relevant to the language team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels May 7, 2019
@Centril Centril mentioned this issue Jul 2, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jul 30, 2019
@Centril
Rollup merge of rust-lang#62293 - Centril:remove-await-macro, r=cramertj
d8280fa 
Unsupport the `await!(future)` macro

Unsupport the `await!(future)` "macro" and recognize it in error recovery instead.

The `future.await` syntax has been on nightly since 2019-05-08.
This was 55 days ago which is 1.31 releases ago.

Closes rust-lang#60610.

r? @cramertj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cramertj cramertj

Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unsupport the await!(future) macro Centril/rust
2 participants
@Centril @cramertj