Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#60030 #60040

Closed
rust-highfive opened this issue Apr 17, 2019 · 3 comments · Fixed by #60071
Closed

miri no longer builds after rust-lang/rust#60030 #60040

rust-highfive opened this issue Apr 17, 2019 · 3 comments · Fixed by #60071
Assignees
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #60030, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 17, 2019
@kennytm
Copy link
Member

kennytm commented Apr 17, 2019

Broken by #59986 @RalfJung

[01:42:45] error[E0407]: method `memory_allocated` is not a member of trait `AllocationExtra`
[01:42:45]    --> src/tools/miri/src/stacked_borrows.rs:476:5
[01:42:45]     |
[01:42:45] 476 | /     fn memory_allocated<'tcx>(size: Size, extra: &MemoryState) -> Self {
[01:42:45] 477 | |         let stack = Stack {
[01:42:45] 478 | |             borrows: vec![BorStackItem::Raw],
[01:42:45] 479 | |             frozen_since: None,
[01:42:45] ...   |
[01:42:45] 484 | |         }
[01:42:45] 485 | |     }
[01:42:45]     | |_____^ not a member of trait `AllocationExtra`
[01:42:45] 
[01:42:45] error[E0407]: method `tag_new_allocation` is not a member of trait `Machine`
[01:42:45]    --> src/tools/miri/src/lib.rs:543:5
[01:42:45]     |
[01:42:45] 543 | /     fn tag_new_allocation(
[01:42:45] 544 | |         ecx: &mut InterpretCx<'a, 'mir, 'tcx, Self>,
[01:42:45] 545 | |         ptr: Pointer,
[01:42:45] 546 | |         kind: MemoryKind<Self::MemoryKinds>,
[01:42:45] ...   |
[01:42:45] 554 | |         }
[01:42:45] 555 | |     }
[01:42:45]     | |_____^ not a member of trait `Machine`
[01:42:45] 
[01:42:45] error[E0107]: wrong number of type arguments: expected 1, found 2
[01:42:45]    --> src/tools/miri/src/stacked_borrows.rs:474:30
[01:42:45]     |
[01:42:45] 474 | impl AllocationExtra<Borrow, MemoryState> for Stacks {
[01:42:45]     |                              ^^^^^^^^^^^ unexpected type argument
[01:42:45] 
[01:42:45] error: aborting due to 3 previous errors
[01:42:45] 
[01:42:45] Some errors occurred: E0107, E0407.
[01:42:45] For more information about an error, try `rustc --explain E0107`.
[01:42:45] [RUSTC-TIMING] miri test:false 1.143
[01:42:45] error: Could not compile `miri`.

@RalfJung
Copy link
Member

Miri fix: rust-lang/miri#695

@RalfJung RalfJung mentioned this issue Apr 18, 2019
@pnkfelix
Copy link
Member

triage: miri breakage gets P-medium.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Apr 18, 2019
bors added a commit that referenced this issue Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants