Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc does not generate documentation for extern blocks. #5953

Closed
pcwalton opened this issue Apr 19, 2013 · 5 comments
Closed

rustdoc does not generate documentation for extern blocks. #5953

pcwalton opened this issue Apr 19, 2013 · 5 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@pcwalton
Copy link
Contributor

Yuck.
@thestinger
Copy link
Contributor

Nominating for the feature complete milestone.

@emberian
Copy link
Member

rustdoc_ng doesn't look into extern blocks. Should it?

@emberian
Copy link
Member

#8125

@emberian
Copy link
Member

cc @pcwalton

@alexcrichton
Copy link
Member

Renaming bug with a more appropriate title now that rustdoc_ng is generating docs. The old title was:

"rustdoc thinks that extern blocks are modules named foreign_mod"

flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 22, 2021
@rail-rain
Add a note on the issue rust-lang#5953
fb54b70
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 22, 2021
@bors
Auto merge of rust-lang#7065 - rail-rain:warn_copy_pass_by_ref, r=Man…
f0ceb28 
…ishearth

Add a note on the issue rust-lang#5953

Hello,

I thought it would be better to have a note and warning about this issue considering it introduced an UB in the past even with the "Search on Github" feature.

---

changelog: Add a note on the issue rust-lang#5953 to the known problems section.
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2022
@bors
Auto merge of rust-lang#8639 - Jarcho:trivially_copy_pass_by_ref_5953…
373bb57 
…, r=dswij

`trivially_copy_pass_by_ref` fixes

fixes rust-lang#5953
fixes rust-lang#2961

The fix for rust-lang#5953 is overly aggressive, but the suggestion is so bad that it's worth the false negatives. Basically three things together:
* It's not obviously wrong
* It compiles
* It may actually work when tested

changelog: Don't lint `trivially_copy_pass_by_ref` when unsafe pointers are used.
changelog: Better track lifetimes when linting `trivially_copy_pass_by_ref`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @pcwalton @emberian @thestinger