Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] ptr::eq source does not mention smart-pointer comparison behavior. #59214

Closed
richard-uk1 opened this issue Mar 15, 2019 · 0 comments
Closed

[docs] ptr::eq source does not mention smart-pointer comparison behavior. #59214

richard-uk1 opened this issue Mar 15, 2019 · 0 comments
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools

Comments

@richard-uk1
Copy link
Contributor

The documentation at the ptr::eq source doesn't mention that smart pointers are compared in their totality, unlike pointer comparison which just compares the addresses. I found out about this behavior on this urlo question.
@kennytm kennytm added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Mar 15, 2019
czipperz added a commit to czipperz/rust that referenced this issue Mar 24, 2019
@czipperz
Make ptr::eq documentation mention smart-pointer behavior
00716b4 
Resolves rust-lang#59214
@czipperz czipperz mentioned this issue Mar 24, 2019
Merged
cuviper added a commit to cuviper/rust that referenced this issue Mar 28, 2019
@cuviper
Rollup merge of rust-lang#59390 - czipperz:ptr_eq_smart_pointer, r=Ce…
35b339b 
…ntril,steveklabnik

Make `ptr::eq` documentation mention fat-pointer behavior

Resolves rust-lang#59214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kennytm @richard-uk1