Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and clean up ty::print some more. #59189

Open
eddyb opened this issue Mar 14, 2019 · 0 comments
Open

Document and clean up ty::print some more. #59189

eddyb opened this issue Mar 14, 2019 · 0 comments
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@eddyb
Copy link
Member

eddyb commented Mar 14, 2019

In order to get #58140 merged before it bitrots again, and needs an eleventh rebase, I've left some of the review comments (by @nikomatsakis) unresolved.

There's also a few things, such as const generics, $(...)? in macros, etc. that weren't possible when the PR was originally authored, but can be taken into account now.
@eddyb eddyb added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Mar 14, 2019
@eddyb eddyb mentioned this issue Mar 14, 2019
Merged
@fmease fmease added A-pretty Area: Pretty printing (including `-Z unpretty`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddyb @fmease