Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After snapshot, update the abi constants in syntax/abi.rs #5423

Closed
nikomatsakis opened this issue Mar 18, 2013 · 3 comments
Closed

After snapshot, update the abi constants in syntax/abi.rs #5423

nikomatsakis opened this issue Mar 18, 2013 · 3 comments
Assignees
@nikomatsakis
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@nikomatsakis
Copy link
Contributor

In syntax/abi.rs (not yet merged in), I had to hardcode various constants due to limitations in the stage0 compiler that appear to have been fixed by others in the meantime.
@ghost ghost assigned nikomatsakis Mar 26, 2013
@pnkfelix
Copy link
Member

I'm insufficiently familiar with the release process to judge how such a change should land. So @nikomatsakis I'm going to assign this to you; if you unassign it from yourself, please also de-milestone it.

@luqmana luqmana mentioned this issue Mar 31, 2013
Merged
@brson
Copy link
Contributor

brson commented Mar 31, 2013

Is this necessary for 0.6?

bors added a commit that referenced this issue Mar 31, 2013
@bors
auto merge of #5637 : luqmana/rust/5423, r=brson
75d615d 
Fixes #5423.
@nikomatsakis
Copy link
Contributor Author

Just code cleanup. Demilestone.

@luqmana luqmana closed this as completed in 02700e0 Apr 2, 2013
oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5423 - rkuhn:add_futures_not_send, r=flip1995
f1fb815 
add lint futures_not_send

changelog: add lint futures_not_send

fixes rust-lang#5379

~Remark: one thing that can (should?) still be improved is to directly include the error message from the `Send` check so that the programmer stays in the flow. Currently, getting the actual error message requires a restructuring of the code to make the `Send` constraint explicit.~
It now shows all unmet constraints for allowing the Future to be Send.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikomatsakis nikomatsakis

Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brson @nikomatsakis @pnkfelix