-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy CTFE/miri #53596
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Comments
RalfJung
added
the
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
label
Aug 22, 2018
@RalfJung I'd like to take this, if that's OK :) |
That's perfect :) Let me know if you need anything! |
@RalfJung Is this the correct license header?
|
Merged
Yeah that looks all right (you first had a different year? My email notification says something else^^) |
@RalfJung Yeah, I had |
Well, yeah^^ |
Hehehe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
CTFE/miri (the code in
src/librustc/mir/interpret
andsrc/librustc_mir/interpret
) is currently exempt from tidy:rust/src/tools/tidy/src/lib.rs
Lines 79 to 80 in 24bc544
That should not be hard to fix, it is mostly a matter of adding a license header everywhere and breaking long lines into less than 100 characters. Basically, start by removing the above two lines from tidy, and then
./x.py --stage 1 test tidy
will tell you all that needs fixing.The text was updated successfully, but these errors were encountered: