Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy CTFE/miri #53596

Closed
RalfJung opened this issue Aug 22, 2018 · 8 comments
Closed

Tidy CTFE/miri #53596

RalfJung opened this issue Aug 22, 2018 · 8 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@RalfJung
Copy link
Member

CTFE/miri (the code in src/librustc/mir/interpret and src/librustc_mir/interpret) is currently exempt from tidy:

"src/librustc/mir/interpret",
"src/librustc_mir/interpret",

That should not be hard to fix, it is mostly a matter of adding a license header everywhere and breaking long lines into less than 100 characters. Basically, start by removing the above two lines from tidy, and then ./x.py --stage 1 test tidy will tell you all that needs fixing.

@RalfJung RalfJung added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Aug 22, 2018
@lovesegfault
Copy link
Contributor

@RalfJung I'd like to take this, if that's OK :)

@RalfJung
Copy link
Member Author

That's perfect :) Let me know if you need anything!

@lovesegfault
Copy link
Contributor

lovesegfault commented Aug 22, 2018

@RalfJung Is this the correct license header?

// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 22, 2018

Yeah that looks all right (you first had a different year? My email notification says something else^^)

@lovesegfault
Copy link
Contributor

@RalfJung Yeah, I had 2013-2015 before, since I just pasted it from some random file, but I updated it to just say 2018

@memoryruins
Copy link
Contributor

Impeccable timing #53617 #53654

@RalfJung
Copy link
Member Author

Well, yeah^^

@lovesegfault
Copy link
Contributor

Hehehe

bors added a commit that referenced this issue Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants