Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop passing stage1/stage2 to compiler build #53582

Closed
Mark-Simulacrum opened this issue Aug 22, 2018 · 0 comments · Fixed by #61494
Closed

Stop passing stage1/stage2 to compiler build #53582

Mark-Simulacrum opened this issue Aug 22, 2018 · 0 comments · Fixed by #61494
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

We should only pass stage0 in general, cfg(not(stage0)) should be sufficient for all use cases.

cc @rust-lang/compiler for awareness and in case there's any concerns
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 22, 2018
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jun 3, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jun 4, 2019
@Centril
Rollup merge of rust-lang#61494 - Mark-Simulacrum:move-to-cfg-bootstr…
f295365 
…ap, r=alexcrichton

Utilize cfg(bootstrap) over cfg(stage0)

Also removes stage1, stage2 cfgs being passed to rustc to ensure that
stage1 and stage2 are only differentiated as a group (i.e., only through
not bootstrap).

Fixes rust-lang#53582

r? @alexcrichton
bors added a commit that referenced this issue Jun 6, 2019
@bors
Auto merge of #61494 - Mark-Simulacrum:move-to-cfg-bootstrap, r=alexc…
51dc52b 
…richton

Utilize cfg(bootstrap) over cfg(stage0)

Also removes stage1, stage2 cfgs being passed to rustc to ensure that
stage1 and stage2 are only differentiated as a group (i.e., only through
not bootstrap).

Fixes #53582

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Utilize cfg(bootstrap) over cfg(stage0) Mark-Simulacrum/rust
1 participant
@Mark-Simulacrum