sysroot spans are not printed on some targets (affected: Debian, rust-lang's own i586; unaffected: Fedora) #53081

infinity0 · 2018-08-05T04:48:36Z

EDIT(@eddyb): For a detailed update/explanation, see #53081 (comment).

I'm trying to track down why we have this diff on all arches, which causes that test to fail:

29	   |
30	LL |     fn hash(&self, hasher: &mut impl Hasher) {}
31	   |                                 ^^^^^^^^^^^ expected generic parameter, found `impl Trait`
-	   | 
-	  ::: $SRC_DIR/libcore/hash/mod.rs:185:13
-	   |
-	LL |     fn hash<H: Hasher>(&self, state: &mut H);
-	   |             - declaration in trait here
37	
38	error: aborting due to 3 previous errors
39

The test passes on Fedora.

Two main things we're doing differently in Debian is that we're currently using cargo 0.27 to build (rather than cargo 0.28) and we also omit some components. However I don't see why either of these should affect the above test output. I also can't see why our other patches should affect it.

The text was updated successfully, but these errors were encountered:

infinity0 · 2018-12-15T18:40:50Z

Our const-size_of-cycle test also fails but passes in Fedora with a similar lack-of-error-details.

diff of stderr:

2	   |
3	note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`...
4	note: ...which requires const-evaluating `Foo::bytes::{{constant}}`...
-	  --> $SRC_DIR/libcore/mem.rs:LL:COL
-	   |
-	LL |     intrinsics::size_of::<T>()
-	   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
9	   = note: ...which again requires computing layout of `Foo`, completing the cycle
10	note: cycle used when const-evaluating `Foo::bytes::{{constant}}`
-	  --> $SRC_DIR/libcore/mem.rs:LL:COL
-	   |
-	LL |     intrinsics::size_of::<T>()
-	   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
15	
16	error: aborting due to previous error
17

infinity0 · 2018-12-15T18:42:27Z

related: #54546

infinity0 · 2018-12-15T18:52:06Z

Strangely, if I run rust's own upstream binary compiler from here the output is also missing error details.

$ rustc/bin/rustc -L$PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib ../const-size_of-cycle.rs
error[E0391]: cycle detected when computing layout of `Foo`
  |
note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`...
note: ...which requires const-evaluating `Foo::bytes::{{constant}}`...
  = note: ...which again requires computing layout of `Foo`, completing the cycle
note: cycle used when const-evaluating `Foo::bytes::{{constant}}`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0391`.

infinity0 · 2018-12-15T19:05:38Z

@oli-obk you created src/test/ui/impl-trait/impl-generic-mismatch.stderr in 00842d1, and @davidtwco you created src/test/ui/compile-fail-migration/const-size_of-cycle.stderr in b16a306, do either of you have any clues about these mismatching error messages?

eddyb · 2018-12-15T19:21:02Z

cc @michaelwoerister This looks like it might be related to file paths for libcore, not being found when running tests.

infinity0 · 2018-12-15T19:27:43Z

FWIW here is the output with RUST_LOG=debug:

$ RUST_LOG=trace rustc/bin/rustc -L$PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib ../const-size_of-cycle.rs
 INFO $TS: jobserver::imp: created a jobserver: Client { read: File { fd: 3, path: "pipe:[57109581]", read: true, write: false }, write: File { fd: 4, path: "pipe:[57109581]", read: false, write: true } }
 INFO $TS: rustc_driver: codegen backend candidate: $PWD/rustc/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends
 INFO $TS: rustc_driver: probing $PWD/rustc/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends for a codegen backend
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate std as std`
 INFO $TS: rustc_metadata::creader: falling back to a load
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-52f862a21e09568c.rlib
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-52f862a21e09568c.so
 INFO $TS: rustc_metadata::locator: rlib reading metadata from: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-52f862a21e09568c.rlib
 INFO $TS: rustc_metadata::locator: reading "libstd-52f862a21e09568c.rlib" => 314.101µs
 INFO $TS: rustc_metadata::creader: register crate `extern crate std as std`
 INFO $TS: rustc_metadata::creader: resolving dep crate core hash: `af89e4eb0280bac6` extra filename: `-f2133e8b70369157`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate core as core`
 INFO $TS: rustc_metadata::creader: falling back to a load
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-f2133e8b70369157.rlib
 INFO $TS: rustc_metadata::locator: rlib reading metadata from: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-f2133e8b70369157.rlib
 INFO $TS: rustc_metadata::locator: reading "libcore-f2133e8b70369157.rlib" => 224.774µs
 INFO $TS: rustc_metadata::creader: register crate `extern crate core as core`
 INFO $TS: rustc_metadata::creader: resolving dep crate compiler_builtins hash: `d04ac580e8a9e993` extra filename: `-71671e8958739d51`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate compiler_builtins as compiler_builtins`
 INFO $TS: rustc_metadata::creader: falling back to a load
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-71671e8958739d51.rlib
 INFO $TS: rustc_metadata::locator: rlib reading metadata from: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-71671e8958739d51.rlib
 INFO $TS: rustc_metadata::locator: reading "libcompiler_builtins-71671e8958739d51.rlib" => 167.677µs
 INFO $TS: rustc_metadata::creader: register crate `extern crate compiler_builtins as compiler_builtins`
 INFO $TS: rustc_metadata::creader: resolving dep crate core hash: `af89e4eb0280bac6` extra filename: `-f2133e8b70369157`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate core as core`
 INFO $TS: rustc_metadata::creader: resolving dep crate alloc hash: `de32cde30cc6bc18` extra filename: `-2d44723f32308cf8`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate alloc as alloc`
 INFO $TS: rustc_metadata::creader: falling back to a load
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-2d44723f32308cf8.rlib
 INFO $TS: rustc_metadata::locator: rlib reading metadata from: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-2d44723f32308cf8.rlib
 INFO $TS: rustc_metadata::locator: reading "liballoc-2d44723f32308cf8.rlib" => 129.342µs
 INFO $TS: rustc_metadata::creader: register crate `extern crate alloc as alloc`
 INFO $TS: rustc_metadata::creader: resolving dep crate core hash: `af89e4eb0280bac6` extra filename: `-f2133e8b70369157`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate core as core`
 INFO $TS: rustc_metadata::creader: resolving dep crate compiler_builtins hash: `d04ac580e8a9e993` extra filename: `-71671e8958739d51`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate compiler_builtins as compiler_builtins`
 INFO $TS: rustc_metadata::creader: resolving dep crate alloc_system hash: `20b374f02cf54767` extra filename: `-48c8a8552cff934e`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate alloc_system as alloc_system`
 INFO $TS: rustc_metadata::creader: falling back to a load
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_system-48c8a8552cff934e.rlib
 INFO $TS: rustc_metadata::locator: rlib reading metadata from: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_system-48c8a8552cff934e.rlib
 INFO $TS: rustc_metadata::locator: reading "liballoc_system-48c8a8552cff934e.rlib" => 54.302µs
 INFO $TS: rustc_metadata::creader: register crate `extern crate alloc_system as alloc_system`
 INFO $TS: rustc_metadata::creader: resolving dep crate core hash: `af89e4eb0280bac6` extra filename: `-f2133e8b70369157`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate core as core`
 INFO $TS: rustc_metadata::creader: resolving dep crate compiler_builtins hash: `d04ac580e8a9e993` extra filename: `-71671e8958739d51`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate compiler_builtins as compiler_builtins`
 INFO $TS: rustc_metadata::creader: resolving dep crate libc hash: `e04f69583f78a1ba` extra filename: `-517830e9d56bab97`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate libc as libc`
 INFO $TS: rustc_metadata::creader: falling back to a load
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-517830e9d56bab97.rlib
 INFO $TS: rustc_metadata::locator: rlib reading metadata from: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-517830e9d56bab97.rlib
 INFO $TS: rustc_metadata::locator: reading "liblibc-517830e9d56bab97.rlib" => 81.651µs
 INFO $TS: rustc_metadata::creader: register crate `extern crate libc as libc`
 INFO $TS: rustc_metadata::creader: resolving dep crate core hash: `af89e4eb0280bac6` extra filename: `-f2133e8b70369157`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate core as core`
 INFO $TS: rustc_metadata::creader: resolving dep crate compiler_builtins hash: `d04ac580e8a9e993` extra filename: `-71671e8958739d51`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate compiler_builtins as compiler_builtins`
 INFO $TS: rustc_metadata::creader: resolving dep crate libc hash: `e04f69583f78a1ba` extra filename: `-517830e9d56bab97`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate libc as libc`
 INFO $TS: rustc_metadata::creader: resolving dep crate unwind hash: `23d16d19bf235477` extra filename: `-4c9cbe622de116ab`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate unwind as unwind`
 INFO $TS: rustc_metadata::creader: falling back to a load
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-4c9cbe622de116ab.rlib
 INFO $TS: rustc_metadata::locator: rlib reading metadata from: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-4c9cbe622de116ab.rlib
 INFO $TS: rustc_metadata::locator: reading "libunwind-4c9cbe622de116ab.rlib" => 53.925µs
 INFO $TS: rustc_metadata::creader: register crate `extern crate unwind as unwind`
 INFO $TS: rustc_metadata::creader: resolving dep crate core hash: `af89e4eb0280bac6` extra filename: `-f2133e8b70369157`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate core as core`
 INFO $TS: rustc_metadata::creader: resolving dep crate compiler_builtins hash: `d04ac580e8a9e993` extra filename: `-71671e8958739d51`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate compiler_builtins as compiler_builtins`
 INFO $TS: rustc_metadata::creader: resolving dep crate libc hash: `e04f69583f78a1ba` extra filename: `-517830e9d56bab97`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate libc as libc`
 INFO $TS: rustc_metadata::creader: resolving dep crate alloc_jemalloc hash: `e11976872a475adc` extra filename: `-a7f738f7aa980965`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate alloc_jemalloc as alloc_jemalloc`
 INFO $TS: rustc_metadata::creader: falling back to a load
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_jemalloc-a7f738f7aa980965.rlib
 INFO $TS: rustc_metadata::locator: rlib reading metadata from: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_jemalloc-a7f738f7aa980965.rlib
 INFO $TS: rustc_metadata::locator: reading "liballoc_jemalloc-a7f738f7aa980965.rlib" => 199.469µs
 INFO $TS: rustc_metadata::creader: register crate `extern crate alloc_jemalloc as alloc_jemalloc`
 INFO $TS: rustc_metadata::creader: resolving dep crate core hash: `af89e4eb0280bac6` extra filename: `-f2133e8b70369157`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate core as core`
 INFO $TS: rustc_metadata::creader: resolving dep crate compiler_builtins hash: `d04ac580e8a9e993` extra filename: `-71671e8958739d51`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate compiler_builtins as compiler_builtins`
 INFO $TS: rustc_metadata::creader: resolving dep crate libc hash: `e04f69583f78a1ba` extra filename: `-517830e9d56bab97`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate libc as libc`
 INFO $TS: rustc_metadata::creader: resolving dep crate panic_unwind hash: `1dcbbefca552f7b5` extra filename: `-b89f1a9b548bfef9`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate panic_unwind as panic_unwind`
 INFO $TS: rustc_metadata::creader: falling back to a load
 INFO $TS: rustc_metadata::locator: lib candidate: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-b89f1a9b548bfef9.rlib
 INFO $TS: rustc_metadata::locator: rlib reading metadata from: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-b89f1a9b548bfef9.rlib
 INFO $TS: rustc_metadata::locator: reading "libpanic_unwind-b89f1a9b548bfef9.rlib" => 62.774µs
 INFO $TS: rustc_metadata::creader: register crate `extern crate panic_unwind as panic_unwind`
 INFO $TS: rustc_metadata::creader: resolving dep crate core hash: `af89e4eb0280bac6` extra filename: `-f2133e8b70369157`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate core as core`
 INFO $TS: rustc_metadata::creader: resolving dep crate compiler_builtins hash: `d04ac580e8a9e993` extra filename: `-71671e8958739d51`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate compiler_builtins as compiler_builtins`
 INFO $TS: rustc_metadata::creader: resolving dep crate alloc hash: `de32cde30cc6bc18` extra filename: `-2d44723f32308cf8`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate alloc as alloc`
 INFO $TS: rustc_metadata::creader: resolving dep crate libc hash: `e04f69583f78a1ba` extra filename: `-517830e9d56bab97`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate libc as libc`
 INFO $TS: rustc_metadata::creader: resolving dep crate unwind hash: `23d16d19bf235477` extra filename: `-4c9cbe622de116ab`
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate unwind as unwind`
 INFO $TS: rustc_driver::driver: 0 parse sess buffered_lints
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate alloc_jemalloc as alloc_jemalloc`
 INFO $TS: rustc_metadata::creader: injecting a dep from 1 to 9
 INFO $TS: rustc_metadata::creader: panic runtime not found -- loading panic_unwind
 INFO $TS: rustc_metadata::creader: resolving crate `extern crate panic_unwind as panic_unwind`
 INFO $TS: rustc_metadata::creader: injecting a dep from 1 to 9
 INFO $TS: rustc_metadata::creader: resolved crates:
 INFO $TS: rustc_metadata::creader:   name: std
 INFO $TS: rustc_metadata::creader:   cnum: 1
 INFO $TS: rustc_metadata::creader:   hash: 55e0028ad01a6c49
 INFO $TS: rustc_metadata::creader:   reqd: Explicit
 INFO $TS: rustc_metadata::creader:   dylib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-52f862a21e09568c.so
 INFO $TS: rustc_metadata::creader:    rlib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-52f862a21e09568c.rlib
 INFO $TS: rustc_metadata::creader:   name: core
 INFO $TS: rustc_metadata::creader:   cnum: 2
 INFO $TS: rustc_metadata::creader:   hash: af89e4eb0280bac6
 INFO $TS: rustc_metadata::creader:   reqd: Explicit
 INFO $TS: rustc_metadata::creader:    rlib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-f2133e8b70369157.rlib
 INFO $TS: rustc_metadata::creader:   name: compiler_builtins
 INFO $TS: rustc_metadata::creader:   cnum: 3
 INFO $TS: rustc_metadata::creader:   hash: d04ac580e8a9e993
 INFO $TS: rustc_metadata::creader:   reqd: Explicit
 INFO $TS: rustc_metadata::creader:    rlib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-71671e8958739d51.rlib
 INFO $TS: rustc_metadata::creader:   name: alloc
 INFO $TS: rustc_metadata::creader:   cnum: 4
 INFO $TS: rustc_metadata::creader:   hash: de32cde30cc6bc18
 INFO $TS: rustc_metadata::creader:   reqd: Explicit
 INFO $TS: rustc_metadata::creader:    rlib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-2d44723f32308cf8.rlib
 INFO $TS: rustc_metadata::creader:   name: alloc_system
 INFO $TS: rustc_metadata::creader:   cnum: 5
 INFO $TS: rustc_metadata::creader:   hash: 20b374f02cf54767
 INFO $TS: rustc_metadata::creader:   reqd: Explicit
 INFO $TS: rustc_metadata::creader:    rlib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_system-48c8a8552cff934e.rlib
 INFO $TS: rustc_metadata::creader:   name: libc
 INFO $TS: rustc_metadata::creader:   cnum: 6
 INFO $TS: rustc_metadata::creader:   hash: e04f69583f78a1ba
 INFO $TS: rustc_metadata::creader:   reqd: Explicit
 INFO $TS: rustc_metadata::creader:    rlib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-517830e9d56bab97.rlib
 INFO $TS: rustc_metadata::creader:   name: unwind
 INFO $TS: rustc_metadata::creader:   cnum: 7
 INFO $TS: rustc_metadata::creader:   hash: 23d16d19bf235477
 INFO $TS: rustc_metadata::creader:   reqd: Explicit
 INFO $TS: rustc_metadata::creader:    rlib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-4c9cbe622de116ab.rlib
 INFO $TS: rustc_metadata::creader:   name: alloc_jemalloc
 INFO $TS: rustc_metadata::creader:   cnum: 8
 INFO $TS: rustc_metadata::creader:   hash: e11976872a475adc
 INFO $TS: rustc_metadata::creader:   reqd: Implicit
 INFO $TS: rustc_metadata::creader:    rlib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_jemalloc-a7f738f7aa980965.rlib
 INFO $TS: rustc_metadata::creader:   name: panic_unwind
 INFO $TS: rustc_metadata::creader:   cnum: 9
 INFO $TS: rustc_metadata::creader:   hash: 1dcbbefca552f7b5
 INFO $TS: rustc_metadata::creader:   reqd: Implicit
 INFO $TS: rustc_metadata::creader:    rlib: $PWD/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-b89f1a9b548bfef9.rlib
error[E0391]: cycle detected when computing layout of `Foo`
  |
note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`...
note: ...which requires const-evaluating `Foo::bytes::{{constant}}`...
  = note: ...which again requires computing layout of `Foo`, completing the cycle
note: cycle used when const-evaluating `Foo::bytes::{{constant}}`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0391`.

Hopefully it's easy to reproduce with rust-lang's own rustc binaries.

infinity0 · 2018-12-15T20:43:58Z

@michaelwoerister would our usage of --remap-path-prefix during the build, be interfering with the tests? If I ln -s src/libcore libcore the compilation output now contains the extra error detail, but the test still fails because the paths are different:

[..]
10	note: cycle used when const-evaluating `Foo::bytes::{{constant}}`
-	  --> $SRC_DIR/libcore/mem.rs:LL:COL
+	  --> libcore/mem.rs:289:5
12	   |
[..]

$ strings ./build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-1361a4a303e9f67c.rlib | rg '/mem\.rs'
libcore/mem.rs
$ strings ./build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-1361a4a303e9f67c.rlib | rg '/usr/src' | sort -u
/usr/src/rustc-1.31.0/src

johnterickson · 2019-02-12T23:52:59Z

I am able to repro this at will in my CI environment if anyone has suggestions on extra logging to add or data to collect.

oli-obk · 2019-02-13T09:10:52Z

I'm not sure what the correct action to resolve this issue is.

Is it to change our test suite so it stops showing code snippets from the standard library?

infinity0 · 2019-02-14T03:52:16Z

One way to fix this, assuming --remap-path-prefix is indeed the problem, is to make this mapping also apply to the definition of $SRC_DIR that the test harness uses. I did take a brief look but wasn't able to figure out how to hook that up, as I recall.

RalfJung · 2019-10-26T13:41:50Z

This affects not just distros building Rust; at least some tests on the i586-unknown-linux-gnu builder in our CI are also affected. So what is the currently recommended fix for that?
I see some tests added // ignore-x86. Is that considered best practice for this issue?

petrochenkov · 2019-10-26T13:44:51Z

I see some tests added // ignore-x86. Is that considered best practice for this issue?

This is certainly not a good practice.
My current suggestion is #65421 (comment).

RalfJung · 2019-10-26T13:50:58Z

This is certainly not a good practice.

This should probably be fixed then.

My current suggestion is #65421 (comment).

That sounds like a hypothetical suggestion that needs libtest work first.
So what is it that we do right now to not block PRs on this one-year-old issue?

RalfJung · 2019-11-02T22:25:00Z

With #66049 I am at least consolidating the existing work-arounds for this problem to all point to this issue here. There's around a dozen instances of this in our test suite.

@estebank

consistent handling of missing sysroot spans Due to rust-lang#53081, sysroot spans (pointing to code in libcore/libstd/...) fails to print on some x86 runners. This consolidates the ignore directives for that and references the relevant issue. I also did that for the generated derive-error-span tests -- but there the script and the tests were not entirely in sync any more since rust-lang#64151. Cc @estebank @varkor

@estebank

consistent handling of missing sysroot spans Due to rust-lang#53081, sysroot spans (pointing to code in libcore/libstd/...) fails to print on some x86 runners. This consolidates the ignore directives for that and references the relevant issue. I also did that for the generated derive-error-span tests -- but there the script and the tests were not entirely in sync any more since rust-lang#64151. Cc @estebank @varkor

estebank · 2019-12-06T00:28:53Z

This seems to have affected windows as well.

Teach `compiletest` to ignore platform triples The UI tests are written assuming `--remap-path-prefix` is *not used* (`remap-debuginfo` in `config.toml`). The consequence is that the error messages may include paths and snippets into the standard library. When `remap-debuginfo` is enabled, these messages change in format and structure because `rustc` will not show paths and snippets into the standard library. This normally isn't a problem for the "main" platforms (linux/macos/windows), because the CI infrastructure is set up so that the tests run without `remap-debuginfo`, but the `dist` artifacts are built separately with `remap-debuginfo` enabled. However, some of the lower-tier platforms perform both tests and distribution in a single step with `remap-debuginfo` enabled. This also affects developers and distributors who use `remap-debuginfo`. To sidestep this problem, we add a way to ignore tests in specific platform triples, and update the overly broad `ignore-x86` rule in affected tests. Address rust-lang#46948, rust-lang#54546, rust-lang#53081.

Teach `compiletest` to ignore platform triples The UI tests are written assuming `--remap-path-prefix` is *not used* (`remap-debuginfo` in `config.toml`). The consequence is that the error messages may include paths and snippets into the standard library. When `remap-debuginfo` is enabled, these messages change in format and structure because `rustc` will not show paths and snippets into the standard library. This normally isn't a problem for the "main" platforms (linux/macos/windows), because the CI infrastructure is set up so that the tests run without `remap-debuginfo`, but the `dist` artifacts are built separately with `remap-debuginfo` enabled. However, some of the lower-tier platforms perform both tests and distribution in a single step with `remap-debuginfo` enabled. This also affects developers and distributors who use `remap-debuginfo`. To sidestep this problem, we add a way to ignore tests in specific platform triples, and update the overly broad `ignore-x86` rule in affected tests. Address #46948, #54546, #53081.

Point at the span for the definition of crate foreign ADTs Follow up to #65421. Partially addresses #65386. Blocked on #53081.

Address rust-lang#53081

Get around rust-lang#53081.

eddyb · 2020-03-31T15:36:02Z

I took a deeper look at this, and the simplest approach for fixing #53486 won't directly fix this.
Or rather, won't fix running tests with remap-debuginfo = true in config.toml.

That's because there's no equivalent to the rust-src rustup component, for the stage{1,2} sysroots that exist while building/testing Rust. We could use a symlink to the real src directory, but I don't think that's supported on all platforms we build on (Windows and/or certain filesystems, AFAIK).

I'll work around that by removing a build/$CFG_COMPILER_HOST_TRIPLE/stage{0-sysroot,1,2} suffix from the sysroot, instead of adding lib/rustlib/src/rust (but only if the latter fails).

I'm also worried this might leak into codegen and cause non-deterministic builds, so we might have to do it only for loading the contents and diagnostics, or probably just gate the rewriting on --remap-path-prefix not being set to rewrite to the same /rustc/$HASH/ that rustc is rewriting to.

For the longest time I was confused and thought this needed "distcheck" to reproduce, but it's really just remap-debuginfo = true, which causes 56 tests to fail for ./x.py test --stage 1 src/test/ui, all of which mention this issue.

The remaining (non-failing) 26 tests that mention the issue are all src/test/ui/derives/derives-span-*.rs (except the Hash ones, since those are part of the failing 56), because src/etc/generate-deriving-span-tests.py generates the // ignores for all of them, even the ones that don't need it.

This comment has been minimized.

Sign in to view

memoryruins added the A-diagnostics Area: Messages for errors, warnings, and lints label Sep 15, 2018

infinity0 changed the title ~~1.28.0 impl-generic-mismatch.stderr differs in Debian~~ Various error details are missing from new ui tests on Debian and rust-lang's own rustc, but OK on Fedora Dec 15, 2018

infinity0 mentioned this issue Dec 15, 2018

rustc should output a warning when it encounters problems locating cross-crate sources for error messages #56860

Open

johnterickson mentioned this issue Feb 12, 2019

[ui] ui/consts/const-size_of-cycle.rs [x86_64-gnu, x86_64-gnu-nopt, x86_64-gnu-distcheck] johnterickson/rust#13

Closed

estebank mentioned this issue Sep 11, 2019

On obligation errors point at the unfulfilled binding when possible #64151

Merged

estebank mentioned this issue Oct 18, 2019

Point at local similarly named element and tweak references to variants #65421

Merged

mati865 mentioned this issue Oct 26, 2019

Make <*const/mut T>::offset_from const fn #63810

Merged

RalfJung changed the title ~~Various error details are missing from new ui tests on Debian and rust-lang's own rustc, but OK on Fedora~~ sysroot spans are not printed on some targets (affected: Debian, rust-lang's own i586; unaffected: Fedora) Oct 26, 2019

RalfJung mentioned this issue Nov 2, 2019

consistent handling of missing sysroot spans #66049

Merged

estebank mentioned this issue Nov 8, 2019

Point at the span for the definition of crate foreign ADTs #65912

Merged

estebank added the I-nominated label Nov 8, 2019

pnkfelix removed the I-nominated label Nov 28, 2019

estebank mentioned this issue Dec 6, 2019

Error message on Windows missing "required by" hint #66860

Closed

This was referenced Dec 15, 2019

Some num tests fail for {i586, i686, x86_64}-unknown-linux-gnu #46948

Closed

Teach compiletest to ignore platform triples #67334

Merged

bors added a commit that referenced this issue Jan 11, 2020

Auto merge of #65912 - estebank:variants-orig, r=petrochenkov

543b7d9

Point at the span for the definition of crate foreign ADTs Follow up to #65421. Partially addresses #65386. Blocked on #53081.

estebank mentioned this issue Jan 22, 2020

Diagnostic: "constant evaluation error" without further details #41893

Closed

estebank added a commit to estebank/rust that referenced this issue Feb 2, 2020

Deal with spans showing std lib

b9c125a

Address rust-lang#53081

estebank added a commit to estebank/rust that referenced this issue Feb 28, 2020

Ignore output for some platforms with diverging test output

2fb35ad

Get around rust-lang#53081.

Aaron1011 mentioned this issue Mar 23, 2020

Store idents for DefPathData into crate metadata #70077

Merged

Aaron1011 added a commit to Aaron1011/rust that referenced this issue Mar 23, 2020

Ignore tests on some platforms due to rust-lang#53081

86b8dea

eddyb mentioned this issue Apr 1, 2020

Translate the virtual /rustc/$hash prefix back to a real directory. #70642

Merged

jonas-schievink mentioned this issue Apr 2, 2020

Hide task_context when lowering body #70640

Merged

bors closed this as completed in c53e4b3 Apr 3, 2020

infinity0 mentioned this issue Jul 26, 2020

sysroot spans still not printed, when remap-path-prefix is set with a custom path #74786

Open

mati865 mentioned this issue Jul 27, 2020

mv std libs to library/ #73265

Merged

Noratrieb added O-x86_32 Target: x86 processors, 32 bit (like i686-*) and removed O-x86-all labels Oct 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sysroot spans are not printed on some targets (affected: Debian, rust-lang's own i586; unaffected: Fedora) #53081

sysroot spans are not printed on some targets (affected: Debian, rust-lang's own i586; unaffected: Fedora) #53081

infinity0 commented Aug 5, 2018 •

edited by eddyb

Loading

This comment has been minimized.

This comment has been minimized.

infinity0 commented Dec 15, 2018

infinity0 commented Dec 15, 2018

infinity0 commented Dec 15, 2018 •

edited

Loading

infinity0 commented Dec 15, 2018

eddyb commented Dec 15, 2018

infinity0 commented Dec 15, 2018

infinity0 commented Dec 15, 2018

johnterickson commented Feb 12, 2019

oli-obk commented Feb 13, 2019

infinity0 commented Feb 14, 2019

RalfJung commented Oct 26, 2019

petrochenkov commented Oct 26, 2019

RalfJung commented Oct 26, 2019

RalfJung commented Nov 2, 2019

estebank commented Dec 6, 2019

eddyb commented Mar 31, 2020

sysroot spans are not printed on some targets (affected: Debian, rust-lang's own i586; unaffected: Fedora) #53081

sysroot spans are not printed on some targets (affected: Debian, rust-lang's own i586; unaffected: Fedora) #53081

Comments

infinity0 commented Aug 5, 2018 • edited by eddyb Loading

This comment has been minimized.

This comment has been minimized.

infinity0 commented Dec 15, 2018

infinity0 commented Dec 15, 2018

infinity0 commented Dec 15, 2018 • edited Loading

infinity0 commented Dec 15, 2018

eddyb commented Dec 15, 2018

infinity0 commented Dec 15, 2018

infinity0 commented Dec 15, 2018

johnterickson commented Feb 12, 2019

oli-obk commented Feb 13, 2019

infinity0 commented Feb 14, 2019

RalfJung commented Oct 26, 2019

petrochenkov commented Oct 26, 2019

RalfJung commented Oct 26, 2019

RalfJung commented Nov 2, 2019

estebank commented Dec 6, 2019

eddyb commented Mar 31, 2020

infinity0 commented Aug 5, 2018 •

edited by eddyb

Loading

infinity0 commented Dec 15, 2018 •

edited

Loading