Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider names of the std::comm types #5300

Closed
brson opened this issue Mar 9, 2013 · 5 comments
Closed

Reconsider names of the std::comm types #5300

brson opened this issue Mar 9, 2013 · 5 comments
Labels
A-concurrency Area: Concurrency A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Mar 9, 2013

The name stream has never felt quite right to me for this function. While it is a descriptive name, it is also generic and heavily overloaded. This is the interface to Rust concurrency, and it will be in the prelude, so it should have a distinct name that we're happy with everybody using forever.

Edit: see comments below. A lot of the names in this module are unsatisfying.
@brson
Copy link
Contributor Author

brson commented Mar 9, 2013

Also rename any associated types

@brson brson mentioned this issue Mar 9, 2013
Closed
@bblum
Copy link
Contributor

bblum commented Mar 23, 2013

It could well be called "pipe".

@Aatch
Copy link
Contributor

Aatch commented Jun 7, 2013

@brson are this and #5301 still relevant? With the new scheduler, we can rename them, since they are already being re-written (though it appears that the current re-implementation shares the naming, is this deliberate?)

@brson
Copy link
Contributor Author

brson commented Jul 31, 2013

Yeah, this is still relevant. We've kept the old names for compatibility. I'm going to update the title to reflect that basically every name in std::comm needs to be reconsidered, GenericFoo, SmartFoo, MegaPipe, oneshot. It's just not cohesive.

@alexcrichton
Copy link
Member

They have been reconsidered! Only Chan, Port, and SharedChan remain.

bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5300 - JohnTitor:edition-flag, r=flip1995
9d5ffe8 
Use `edition:2018` flag more widely

Now we recommend using `// edition:2018`, so let's use it more widely.
Also replace a too old example with new one in the docs.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-concurrency Area: Concurrency A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
4 participants
@alexcrichton @brson @Aatch @bblum