Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do catch is accidentally stable in 2018 edition #52604

Closed
scottmcm opened this issue Jul 22, 2018 · 0 comments
Closed

do catch is accidentally stable in 2018 edition #52604

scottmcm opened this issue Jul 22, 2018 · 0 comments
Labels
WG-epoch Working group: Epoch (2018) management
Milestone
Rust 2018 Preview 2

Comments

@scottmcm
Copy link
Member

This works with no #![feature]:

fn main() {
    let x: Option<_> = do catch { 4 };
}

https://play.rust-lang.org/?gist=ed21b1848a1114ed7f7fefc13bdb8880&version=nightly&mode=debug&edition=2018

I expect this to be fixed with #52602, but wanted to file explicitly for tracking.
@scottmcm scottmcm mentioned this issue Jul 22, 2018
Merged
@scottmcm scottmcm added the WG-epoch Working group: Epoch (2018) management label Jul 22, 2018
@scottmcm scottmcm added this to the Rust 2018 Release Candidate milestone Jul 22, 2018
@joshtriplett joshtriplett mentioned this issue Aug 6, 2018
Merged
joshtriplett added a commit to joshtriplett/rust that referenced this issue Aug 6, 2018
@joshtriplett
Rust 2018: Disable catch_expr, not targeted for 2018 edition
1fd8e57 
Fixes rust-lang#52604
kennytm added a commit to kennytm/rust that referenced this issue Aug 7, 2018
@kennytm
Rollup merge of rust-lang#53135 - joshtriplett:remove-catch-from-2018…
9da780d 
…-preview, r=Mark-Simulacrum

Rust 2018: Disable catch_expr, not targeted for 2018 edition

Fixes rust-lang#52604
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Aug 22, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#52602 - scottmcm:tryblock-expr, r=nikomatsakis
9146d03 
Implement try block expressions

I noticed that `try` wasn't a keyword yet in Rust 2018, so...

~~Fix​es rust-lang#52604 That was fixed by PR rust-lang#53135
cc rust-lang#31436 rust-lang#50412
bors added a commit that referenced this issue Aug 23, 2018
@bors
Auto merge of #52602 - scottmcm:tryblock-expr, r=nikomatsakis
35bf1ae 
Implement try block expressions

I noticed that `try` wasn't a keyword yet in Rust 2018, so...

~~Fix​es #52604 That was fixed by PR #53135
cc #31436 #50412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WG-epoch Working group: Epoch (2018) management
Projects
None yet
Milestone
Rust 2018 Preview 2
Development

No branches or pull requests
2 participants
@joshtriplett @scottmcm