You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since 7948afd the compare_source check no longer panics on failure. It is obvious in the commit that the panic invocation is removed from the check, and no other changes are made in the function to remedy it.
It can be verified by adding a new pretty test case like:
// pp-exact
// The next line should not be expanded
mod issue_12590_b;
The resulting pretty printed file is slightly different, the comparison fails and the message is logged, but the test continues into the type check, which fails for a different reason and then panics. If you fix the type check (by adding the module and fn main) then the whole test passes and the error message is swallowed even though the source comparison is still not matching.
The text was updated successfully, but these errors were encountered:
Centril
added
C-bug
Category: This is a bug.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Jul 11, 2018
make pretty source comparison check be fatal (fixes#52255)
This is not ready for merging because it reveals (at least) two regressions in the pretty suite. Should I attempt to fix those in this PR also?
Since 7948afd the
compare_source
check no longer panics on failure. It is obvious in the commit that thepanic
invocation is removed from the check, and no other changes are made in the function to remedy it.It can be verified by adding a new pretty test case like:
The resulting pretty printed file is slightly different, the comparison fails and the message is logged, but the test continues into the type check, which fails for a different reason and then panics. If you fix the type check (by adding the module and fn main) then the whole test passes and the error message is swallowed even though the source comparison is still not matching.
The text was updated successfully, but these errors were encountered: