Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate str::slice_unchecked and str::slice_unchecked_mut? #51715

Closed
newpavlov opened this issue Jun 22, 2018 · 0 comments
Closed

Deprecate str::slice_unchecked and str::slice_unchecked_mut? #51715

newpavlov opened this issue Jun 22, 2018 · 0 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@newpavlov
Copy link
Contributor

IIUC those methods duplicate functionality of get_unchecked and get_uncheked_mut.

Relevant issue: #35097
@stokhos stokhos added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jun 22, 2018
@frewsxcv frewsxcv added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 23, 2018
@newpavlov newpavlov mentioned this issue Jun 26, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Jul 21, 2018
@kennytm
Rollup merge of rust-lang#51807 - newpavlov:deprecate_str_slice, r=al…
590c971 
…excrichton

Deprecation of str::slice_unchecked(_mut)

Closes rust-lang#51715

I am not sure if 1.28.0 or 1.29.0 should be used for deprecation version, for now it's 1.28.0.

Additionally I've replaced `slice_unchecked` uses with `get_unchecked`. The only places where this method is still used are `src/liballoc/tests/str.rs` and `src/liballoc/tests/str.rs`.
kennytm added a commit to kennytm/rust that referenced this issue Jul 22, 2018
@kennytm
Rollup merge of rust-lang#51807 - newpavlov:deprecate_str_slice, r=al…
67cf3ba 
…excrichton

Deprecation of str::slice_unchecked(_mut)

Closes rust-lang#51715

I am not sure if 1.28.0 or 1.29.0 should be used for deprecation version, for now it's 1.28.0.

Additionally I've replaced `slice_unchecked` uses with `get_unchecked`. The only places where this method is still used are `src/liballoc/tests/str.rs` and `src/liballoc/tests/str.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@newpavlov @frewsxcv @stokhos