Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable ThinLTO on CI #48222

Closed
Mark-Simulacrum opened this issue Feb 15, 2018 · 2 comments
Closed

Re-enable ThinLTO on CI #48222

Mark-Simulacrum opened this issue Feb 15, 2018 · 2 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

We previously disabled it on the dist bots, but this is currently untenable due to the length of time they run for. Should be relatively straightforward, we need to remove this line.

cc @kennytm @alexcrichton

@Mark-Simulacrum Mark-Simulacrum added P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 15, 2018
@kennytm
Copy link
Member

kennytm commented Feb 15, 2018

Do we need to reopen #45444 when this issue (#48222) is closed?

@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Feb 15, 2018

I think we'll probably for now just take that perf hit on stable/beta releases but there's been some thought about disabling ThinLTO only for nightly, not stable/beta builds.

Edit: Rather, enabling ThinLTO only on nightly, and codegen-units=1 for stable/beta.

@XAMPPRocky XAMPPRocky added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants