Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: theme switcher button in awkward locations on mobile #47723

Closed
QuietMisdreavus opened this issue Jan 24, 2018 · 1 comment
Closed

rustdoc: theme switcher button in awkward locations on mobile #47723

QuietMisdreavus opened this issue Jan 24, 2018 · 1 comment
Assignees
@GuillaumeGomez
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@QuietMisdreavus
Copy link
Member

When viewing docs on mobile, the "switch theme" button is placed into the top bar. However, this overlaps the crate version indicator on the crate root:

image

When the sidebar menu is opened, the button is instead placed into that sidebar menu, but can also overlap text there:

image
@QuietMisdreavus QuietMisdreavus added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 24, 2018
@GuillaumeGomez
Copy link
Member

That's a funny one!

@GuillaumeGomez GuillaumeGomez self-assigned this Jan 24, 2018
@cuviper cuviper added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools-rustdoc labels Jan 27, 2018
@GuillaumeGomez GuillaumeGomez mentioned this issue Jan 27, 2018
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 7, 2018
@Manishearth
Rollup merge of rust-lang#47810 - GuillaumeGomez:fix-theme-but-positi…
185f258 
…on, r=QuietMisdreavus

Fix rendering issues on mobile

Fixes rust-lang#47723

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cuviper @GuillaumeGomez @QuietMisdreavus