-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old quasi quoting APIs #46849
Comments
Cargo landed. Blocked on rust-lang/rust-clippy#2283 |
Clippy is also now fixed. I believe the main decision to be made here is whether to remove the old quote_ tests unilaterally or attempt to likewise convert them to either proc_macro and/or manual expansions of the If we're to just remove them, then this should be a fairly easy PR to make. |
Okay, so the code that needs to be changed is at Lines 85 to 101 in e063518
Then delete the tests for it. There shouldn't be any uses left. |
Seems that cargo still uses |
Remove quote feature use Quote is being removed see rust-lang/rust#46849. Follow up of @Manishearth 's #4838 which removed usages of the feature so now we only have to remove `quote` from the `#![feature]` attrs.
Remove quote_*! macros This deletes a considerable amount of test cases, some of which we may want to keep. I'm not entirely certain what the primary intent of many of them was; if we should keep them I can attempt to edit each case to continue compiling without the quote_*! macros involved. Fixes #46849. Fixes #12265. Fixes #12266. r? @Manishearth
Remove quote_*! macros This deletes a considerable amount of test cases, some of which we may want to keep. I'm not entirely certain what the primary intent of many of them was; if we should keep them I can attempt to edit each case to continue compiling without the quote_*! macros involved. Fixes #46849. Fixes #12265. Fixes #12266. r? @Manishearth
Remove quote_*! macros This deletes a considerable amount of test cases, some of which we may want to keep. I'm not entirely certain what the primary intent of many of them was; if we should keep them I can attempt to edit each case to continue compiling without the quote_*! macros involved. Fixes #46849. Fixes #12265. Fixes #12266. Fixes #26994. r? @Manishearth
Remove quote_*! macros This deletes a considerable amount of test cases, some of which we may want to keep. I'm not entirely certain what the primary intent of many of them was; if we should keep them I can attempt to edit each case to continue compiling without the quote_*! macros involved. Fixes #46849. Fixes #12265. Fixes #12266. Fixes #26994. r? @Manishearth
We still have the
quote_foo!
macros. They aren't used anywhere within rustc, and they are used by cargo and clippy for testing syntax extension related things.We can update cargo and clippy to use other APIs (and eventually move them to TokenStream).
rust-lang/cargo#4838 is the cargo PR; will make a clippy one shortly.
The text was updated successfully, but these errors were encountered: