Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc nightly: search deduplication can cause missing items #45968

Closed
crumblingstatue opened this issue Nov 13, 2017 · 7 comments
Closed

rustdoc nightly: search deduplication can cause missing items #45968

crumblingstatue opened this issue Nov 13, 2017 · 7 comments
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@crumblingstatue
Copy link
Contributor

crumblingstatue commented Nov 13, 2017 •
edited
Loading

This example is outdated, but in it, thread::spawn is missing in nightly.

stable:

nightly:

Probably caused by ee7e372.
@sfackler sfackler added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. labels Nov 13, 2017
@TimNN TimNN added the C-bug Category: This is a bug. label Nov 14, 2017
@crumblingstatue
Copy link
Contributor Author

crumblingstatue commented Nov 15, 2017 •
edited
Loading

This seems fixed on (ff0f5de3b 2017-11-14), but I don't know if a regression test should be added or something, so I'll leave this open for now.

EDIT: It's not fixed, see comment below.

@kennytm kennytm added E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. and removed regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. labels Nov 15, 2017
@ollie27
Copy link
Member

ollie27 commented Nov 16, 2017

This isn't fixed. Now std::thread::Builder::spawn is missing. I believe this was originally caused by ee7e372 (cc @GuillaumeGomez). It seems to be de-duplicating search results based on path + name ignoring parent and ty so it's treating std::thread::spawn and std::thread::Builder::spawn as the same.

@kennytm kennytm added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. and removed E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. labels Nov 16, 2017
@crumblingstatue crumblingstatue changed the title rustdoc nightly: thread::spawn not shown when searching for spawn rustdoc nightly: deduplication can cause missing items Nov 16, 2017
@crumblingstatue crumblingstatue changed the title rustdoc nightly: deduplication can cause missing items rustdoc nightly: search deduplication can cause missing items Nov 16, 2017
@GuillaumeGomez
Copy link
Member

I have to wait for both of my rustdoc PRs here and here) to be merged before looking for this.

@durka
Copy link
Contributor

durka commented Nov 28, 2017

Searching for read_to_end in the nightly docs doesn't come up with std::io::Read::read_to_end. Is this the same issue?

@GuillaumeGomez
Copy link
Member

Maybe? I'll take a look as well.

@GuillaumeGomez GuillaumeGomez self-assigned this Dec 1, 2017
@GuillaumeGomez
Copy link
Member

Can you confirm once again? When I just tested on nightly, it worked as expected?

@GuillaumeGomez
Copy link
Member

@durka: However, your issue is still there. Taking a look.

@GuillaumeGomez GuillaumeGomez mentioned this issue Dec 1, 2017
Merged
bors added a commit that referenced this issue Dec 3, 2017
@bors
Auto merge of #46433 - GuillaumeGomez:dedup-items, r=QuietMisdreavus
d0ebb4d 
Fix deduplication of items

Fixes #45968.

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@durka @kennytm @TimNN @sfackler @crumblingstatue @arielb1 @GuillaumeGomez @ollie27