-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't compile core for msp430 in release mode #45836
Labels
C-bug
Category: This is a bug.
Comments
Heh yeah I'd definitely beleive that! Anything related to the "don't use the integrated assembler" breaks all the time... |
11 tasks
pftbest
added a commit
to pftbest/rust
that referenced
this issue
Jan 15, 2018
Old implementation called the assembler once per crate, but we need to call it for each object file instead, because a single crate can now have more than one object file. This patch fixes issue rust-lang#45836 (Can't compile core for msp430 in release mode)
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Jan 25, 2018
Fix no_integrated_as option to work with new codegen architecture. Old implementation called the assembler once per crate, but we need to call it for each object file instead, because a single crate can now have more than one object file. This patch fixes issue rust-lang#45836 (Can't compile core for msp430 in release mode) This change can be tested on x86_64 using ```sh export RUSTFLAGS="-C no_integrated_as -C save_temps" ``` r? @alexcrichton cc @japaric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cc @alexcrichton seems related to the thinLTO / codegen-unit changes. Seems like the name of the intermediate .s artifact changed but the "external assembler" logic wasn't updated to match the new name.
The text was updated successfully, but these errors were encountered: