Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rustdoc] left panel misrepresents negative OIBITs #45816

Closed
cuviper opened this issue Nov 6, 2017 · 0 comments
Closed

[rustdoc] left panel misrepresents negative OIBITs #45816

cuviper opened this issue Nov 6, 2017 · 0 comments
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@cuviper
Copy link
Member

cuviper commented Nov 6, 2017

The list of trait implementations in the left panel includes OIBITs that are explicitly not implemented, without indicating that it's a negative impl. For example, mpsc::Sender has !Sync, but at a glance the left panel would imply that it's a normal Sync.

Sender docs screen capture
@kennytm kennytm added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Nov 7, 2017
@GuillaumeGomez GuillaumeGomez mentioned this issue Nov 20, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this issue Nov 21, 2017
@kennytm
Rollup merge of rust-lang#46134 - GuillaumeGomez:negative-traits, r=Q…
3bf1328 
…uietMisdreavus

Display negative traits implementation

Fixes rust-lang#45816.

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuviper @kennytm