-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resolve] use rename suggestion is not well-formatted #45799
Comments
Looks like the feature works fine for |
Whoops! Thanks for noticing that. I should be able to look into fixing this tonight (~12 hours from now) or tomorrow. @estebank, may I ask if you have any comments or input as to how this should be fixed before I do so? |
@Cldfire what I would do is change the |
Gotcha, thanks for the advice. |
rust/src/librustc_resolve/lib.rs
Lines 3703 to 3706 in 44990e5
Trying to re-import
std
or any other crate, I get a suggestion like this:The problem is in the formatting of the suggestion, where SEMICOLON (
;
) is placed before theas
keyword, like thisextern crate std; as Otherstd
instead ofextern crate std as Otherstd;
.The suggestion doesn't exist in stable or beta, so this affects only nightly at the moment.
Original commit: ff83240
Original PR: #45660
/cc @Cldfire
The text was updated successfully, but these errors were encountered: