Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious test failure: net::tcp::tests::connect_timeout_unroutable #44645

Closed
tmerr opened this issue Sep 17, 2017 · 0 comments
Closed

Spurious test failure: net::tcp::tests::connect_timeout_unroutable #44645

tmerr opened this issue Sep 17, 2017 · 0 comments

Comments

@tmerr
Copy link
Contributor

tmerr commented Sep 17, 2017 •
edited
Loading

What I tried: ./x.py test src/libstd on a laptop disconnected from wifi, running linux
What I expected: tests pass
What I got: tests pass except net::tcp::tets::connect_timeout_unroutable.

thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `Other`,
 right: `TimedOut`', src/libstd/net/tcp.rs:test 1576:8

Underlying error: Error { repr: Os { code: 101, message: "Network is unreachable" } }.

Should the test suite be assuming we are on some network?
tmerr added a commit to tmerr/rust that referenced this issue Sep 17, 2017
@tmerr
Ensure tcp test case passes when disconnected from network
fcdd46e 
net::tcp::tests::connect_timeout_unroutable fails when the network
is unreachable, like on a laptop disconnected from wifi. Check for
this error and allow the test to pass.

Closes rust-lang#44645
@tmerr tmerr mentioned this issue Sep 17, 2017
Merged
TimNN added a commit to TimNN/rust that referenced this issue Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44647 - tmerr:fix-44645, r=dtolnay
7e08a23 
Ensure tcp test case passes when disconnected from network

net::tcp::tests::connect_timeout_unroutable fails when the network
is unreachable, like on a laptop disconnected from wifi. Check for
this error and allow the test to pass.

Closes rust-lang#44645
TimNN added a commit to TimNN/rust that referenced this issue Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44647 - tmerr:fix-44645, r=dtolnay
f189423 
Ensure tcp test case passes when disconnected from network

net::tcp::tests::connect_timeout_unroutable fails when the network
is unreachable, like on a laptop disconnected from wifi. Check for
this error and allow the test to pass.

Closes rust-lang#44645
TimNN added a commit to TimNN/rust that referenced this issue Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44647 - tmerr:fix-44645, r=dtolnay
7aefb6c 
Ensure tcp test case passes when disconnected from network

net::tcp::tests::connect_timeout_unroutable fails when the network
is unreachable, like on a laptop disconnected from wifi. Check for
this error and allow the test to pass.

Closes rust-lang#44645
@nnethercote nnethercote mentioned this issue Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmerr