Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 1.19 regression, odds 0.2.25, splice method #42462

Closed
brson opened this issue Jun 6, 2017 · 6 comments
Closed

Rust 1.19 regression, odds 0.2.25, splice method #42462

brson opened this issue Jun 6, 2017 · 6 comments
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 6, 2017 •
edited
Loading

Caused by either #41670 or #40434

Jun 03 18:48:16.519 INFO testing odds-0.2.25 against nightly for nightly-2017-06-01
Jun 03 18:48:16.519 INFO running: cargo +nightly build --frozen
Jun 03 18:48:16.519 INFO creating container for: cargo +nightly build --frozen
Jun 03 18:48:16.519 INFO running `docker create -v /home/ec2-user/cargobomb/./work/local/test-source/nightly-2017-06-01/nightly:/source:ro -v /home/ec2-user/cargobomb/./work/local/cargo-home:/cargo-home:ro -v /home/ec2-user/cargobomb/./work/local/rustup-home:/rustup-home:ro -v /home/ec2-user/cargobomb/./work/local/target-dirs/nightly-2017-06-01/nightly:/target:rw -e USER_ID=500 -e CMD=cargo +nightly build --frozen cargobomb`
Jun 03 18:48:16.592 INFO blam! 47070253b989752985c7ca50c249f57fa6c78305029a58648357cd62dc19d17f
Jun 03 18:48:16.592 INFO running `docker start -a 47070253b989752985c7ca50c249f57fa6c78305029a58648357cd62dc19d17f`
Jun 03 18:48:16.914 INFO kablam!    Compiling odds v0.2.25 (file:///source)
Jun 03 18:48:17.997 INFO kablam!     Finished dev [unoptimized + debuginfo] target(s) in 1.8 secs
Jun 03 18:48:18.000 INFO kablam! su: No module specific data is present
Jun 03 18:48:18.324 INFO running `docker rm -f 47070253b989752985c7ca50c249f57fa6c78305029a58648357cd62dc19d17f`
Jun 03 18:48:18.340 INFO blam! 47070253b989752985c7ca50c249f57fa6c78305029a58648357cd62dc19d17f
Jun 03 18:48:18.340 INFO running: cargo +nightly test --frozen --no-run
Jun 03 18:48:18.340 INFO creating container for: cargo +nightly test --frozen --no-run
Jun 03 18:48:18.340 INFO running `docker create -v /home/ec2-user/cargobomb/./work/local/test-source/nightly-2017-06-01/nightly:/source:ro -v /home/ec2-user/cargobomb/./work/local/cargo-home:/cargo-home:ro -v /home/ec2-user/cargobomb/./work/local/rustup-home:/rustup-home:ro -v /home/ec2-user/cargobomb/./work/local/target-dirs/nightly-2017-06-01/nightly:/target:rw -e USER_ID=500 -e CMD=cargo +nightly test --frozen --no-run cargobomb`
Jun 03 18:48:18.421 INFO blam! 4a88072303649b3c2bffaff3e66b7e2697b1db7000f1c52c40662e58062f5e70
Jun 03 18:48:18.421 INFO running `docker start -a 4a88072303649b3c2bffaff3e66b7e2697b1db7000f1c52c40662e58062f5e70`
Jun 03 18:48:18.734 INFO kablam!    Compiling odds v0.2.25 (file:///source)
Jun 03 18:48:19.450 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:19.450 INFO kablam!    --> src/vec.rs:184:7
Jun 03 18:48:19.450 INFO kablam!     |
Jun 03 18:48:19.451 INFO kablam! 184 |     v.splice(1..1, vec![9, 9]);
Jun 03 18:48:19.451 INFO kablam!     |       ^^^^^^
Jun 03 18:48:19.451 INFO kablam!     |
Jun 03 18:48:19.451 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:19.451 INFO kablam! 
Jun 03 18:48:19.455 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:19.455 INFO kablam!    --> src/vec.rs:188:7
Jun 03 18:48:19.455 INFO kablam!     |
Jun 03 18:48:19.455 INFO kablam! 188 |     v.splice(1..2, vec![9, 9]);
Jun 03 18:48:19.455 INFO kablam!     |       ^^^^^^
Jun 03 18:48:19.455 INFO kablam!     |
Jun 03 18:48:19.455 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:19.455 INFO kablam! 
Jun 03 18:48:19.458 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:19.458 INFO kablam!    --> src/vec.rs:192:7
Jun 03 18:48:19.458 INFO kablam!     |
Jun 03 18:48:19.458 INFO kablam! 192 |     v.splice(1..4, vec![9, 9]);
Jun 03 18:48:19.458 INFO kablam!     |       ^^^^^^
Jun 03 18:48:19.458 INFO kablam!     |
Jun 03 18:48:19.458 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:19.458 INFO kablam! 
Jun 03 18:48:19.460 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:19.460 INFO kablam!    --> src/vec.rs:196:7
Jun 03 18:48:19.460 INFO kablam!     |
Jun 03 18:48:19.460 INFO kablam! 196 |     v.splice(0..4, once(9));
Jun 03 18:48:19.460 INFO kablam!     |       ^^^^^^
Jun 03 18:48:19.460 INFO kablam!     |
Jun 03 18:48:19.460 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:19.460 INFO kablam! 
Jun 03 18:48:19.463 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:19.463 INFO kablam!    --> src/vec.rs:200:7
Jun 03 18:48:19.463 INFO kablam!     |
Jun 03 18:48:19.463 INFO kablam! 200 |     v.splice(0..4, None);
Jun 03 18:48:19.463 INFO kablam!     |       ^^^^^^
Jun 03 18:48:19.463 INFO kablam!     |
Jun 03 18:48:19.463 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:19.463 INFO kablam! 
Jun 03 18:48:19.466 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:19.466 INFO kablam!    --> src/vec.rs:204:7
Jun 03 18:48:19.466 INFO kablam!     |
Jun 03 18:48:19.466 INFO kablam! 204 |     v.splice(1.., Some(9));
Jun 03 18:48:19.466 INFO kablam!     |       ^^^^^^
Jun 03 18:48:19.466 INFO kablam!     |
Jun 03 18:48:19.466 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:19.466 INFO kablam! 
Jun 03 18:48:19.746 INFO kablam! error: aborting due to previous error(s)
Jun 03 18:48:19.746 INFO kablam! 
Jun 03 18:48:19.756 INFO blam! Build failed, waiting for other jobs to finish...
Jun 03 18:48:19.756 INFO kablam! error: Could not compile `odds`.
Jun 03 18:48:20.187 INFO kablam! error: build failed
Jun 03 18:48:20.190 INFO kablam! su: No module specific data is present
Jun 03 18:48:20.523 INFO running `docker rm -f 4a88072303649b3c2bffaff3e66b7e2697b1db7000f1c52c40662e58062f5e70`
Jun 03 18:48:20.540 INFO blam! 4a88072303649b3c2bffaff3e66b7e2697b1db7000f1c52c40662e58062f5e70
Jun 03 18:48:20.540 INFO running: cargo +nightly test --frozen
Jun 03 18:48:20.540 INFO creating container for: cargo +nightly test --frozen
Jun 03 18:48:20.540 INFO running `docker create -v /home/ec2-user/cargobomb/./work/local/test-source/nightly-2017-06-01/nightly:/source:ro -v /home/ec2-user/cargobomb/./work/local/cargo-home:/cargo-home:ro -v /home/ec2-user/cargobomb/./work/local/rustup-home:/rustup-home:ro -v /home/ec2-user/cargobomb/./work/local/target-dirs/nightly-2017-06-01/nightly:/target:rw -e USER_ID=500 -e CMD=cargo +nightly test --frozen cargobomb`
Jun 03 18:48:20.609 INFO blam! c5a3d6c88c70b065126f7b7b6994b70918d07619dab7c17992e44034a328e669
Jun 03 18:48:20.610 INFO running `docker start -a c5a3d6c88c70b065126f7b7b6994b70918d07619dab7c17992e44034a328e669`
Jun 03 18:48:20.926 INFO kablam!    Compiling odds v0.2.25 (file:///source)
Jun 03 18:48:21.559 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:21.559 INFO kablam!    --> src/vec.rs:184:7
Jun 03 18:48:21.559 INFO kablam!     |
Jun 03 18:48:21.559 INFO kablam! 184 |     v.splice(1..1, vec![9, 9]);
Jun 03 18:48:21.559 INFO kablam!     |       ^^^^^^
Jun 03 18:48:21.559 INFO kablam!     |
Jun 03 18:48:21.559 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:21.559 INFO kablam! 
Jun 03 18:48:21.563 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:21.563 INFO kablam!    --> src/vec.rs:188:7
Jun 03 18:48:21.563 INFO kablam!     |
Jun 03 18:48:21.563 INFO kablam! 188 |     v.splice(1..2, vec![9, 9]);
Jun 03 18:48:21.563 INFO kablam!     |       ^^^^^^
Jun 03 18:48:21.563 INFO kablam!     |
Jun 03 18:48:21.563 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:21.563 INFO kablam! 
Jun 03 18:48:21.565 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:21.565 INFO kablam!    --> src/vec.rs:192:7
Jun 03 18:48:21.565 INFO kablam!     |
Jun 03 18:48:21.565 INFO kablam! 192 |     v.splice(1..4, vec![9, 9]);
Jun 03 18:48:21.565 INFO kablam!     |       ^^^^^^
Jun 03 18:48:21.565 INFO kablam!     |
Jun 03 18:48:21.565 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:21.565 INFO kablam! 
Jun 03 18:48:21.567 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:21.567 INFO kablam!    --> src/vec.rs:196:7
Jun 03 18:48:21.567 INFO kablam!     |
Jun 03 18:48:21.567 INFO kablam! 196 |     v.splice(0..4, once(9));
Jun 03 18:48:21.567 INFO kablam!     |       ^^^^^^
Jun 03 18:48:21.568 INFO kablam!     |
Jun 03 18:48:21.568 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:21.568 INFO kablam! 
Jun 03 18:48:21.570 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:21.570 INFO kablam!    --> src/vec.rs:200:7
Jun 03 18:48:21.570 INFO kablam!     |
Jun 03 18:48:21.570 INFO kablam! 200 |     v.splice(0..4, None);
Jun 03 18:48:21.570 INFO kablam!     |       ^^^^^^
Jun 03 18:48:21.570 INFO kablam!     |
Jun 03 18:48:21.570 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:21.570 INFO kablam! 
Jun 03 18:48:21.573 INFO kablam! error: use of unstable library feature 'splice': recently added (see issue #32310)
Jun 03 18:48:21.573 INFO kablam!    --> src/vec.rs:204:7
Jun 03 18:48:21.573 INFO kablam!     |
Jun 03 18:48:21.573 INFO kablam! 204 |     v.splice(1.., Some(9));
Jun 03 18:48:21.573 INFO kablam!     |       ^^^^^^
Jun 03 18:48:21.573 INFO kablam!     |
Jun 03 18:48:21.573 INFO kablam!     = help: add #![feature(splice)] to the crate attributes to enable
Jun 03 18:48:21.573 INFO kablam! 
Jun 03 18:48:21.818 INFO kablam! error: aborting due to previous error(s)
Jun 03 18:48:21.818 INFO kablam! 
Jun 03 18:48:21.827 INFO kablam! error: Could not compile `odds`.
Jun 03 18:48:21.827 INFO kablam! 
Jun 03 18:48:21.827 INFO kablam! To learn more, run the command again with --verbose.
Jun 03 18:48:21.830 INFO kablam! su: No module specific data is present
Jun 03 18:48:22.190 INFO running `docker rm -f c5a3d6c88c70b065126f7b7b6994b70918d07619dab7c17992e44034a328e669`
Jun 03 18:48:22.205 INFO blam! c5a3d6c88c70b065126f7b7b6994b70918d07619dab7c17992e44034a328e669

cc @bluss
@brson brson added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Jun 6, 2017
@bluss bluss mentioned this issue Jun 7, 2017
Closed
@bluss
Copy link
Member

bluss commented Jun 7, 2017

Thanks for filing! Unfortunate conflict due to precedence of inherent methods.

@scottmcm
Copy link
Member

scottmcm commented Jun 7, 2017

step_by is having the same problem: two methods with the same name in different feature gates.

Would it be insane for name resolution to be #![feature]-aware?

@sfackler
Copy link
Member

sfackler commented Jun 7, 2017

Someone needs to do the work.

@bluss
Copy link
Member

bluss commented Jun 8, 2017

The crate odds is not broken, only some of its tests are. It is though a foretelling of what a few of the users of odds will see if they use that particular method called splice, or if they defined their own splice the same way. It means that the crate doesn't have to do anything hard, and very few are affected.

@nikomatsakis
Copy link
Contributor

We've previously decided against making name resolution feature-aware, precisely because we want to know about conflicts before they happen.

@brson brson added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 15, 2017
@brson
Copy link
Contributor Author

brson commented Jun 15, 2017

Closing as expected libs breakage. Sadly.

@brson brson closed this as completed Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brson @nikomatsakis @sfackler @bluss @scottmcm