Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear if From<Ipv4Addr> for u32 is network order or not #40118

Closed
nagisa opened this issue Feb 26, 2017 · 4 comments · Fixed by #40590
Closed

Unclear if From<Ipv4Addr> for u32 is network order or not #40118

nagisa opened this issue Feb 26, 2017 · 4 comments · Fixed by #40590
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority

Comments

@nagisa
Copy link
Member

nagisa commented Feb 26, 2017

The conversion traits are implemented for conversion between u32 and Ipv4Addr, but it is not clear what byte order is used.
@sfackler
Copy link
Member

It is network order, but that should be documented on the impl.

@steveklabnik steveklabnik added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority and removed A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Mar 10, 2017
@steveklabnik
Copy link
Member

doc team triage: this would make a great first PR. I am happy to mentor anyone who wants to tackle this issue.

@ghost
Copy link

ghost commented Mar 16, 2017

@steveklabnik I'd like to, is someone else working on this?

@steveklabnik
Copy link
Member

@z1mvader nope, please do! Ping me if you need any help 😄

@ghost ghost mentioned this issue Mar 17, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
ac1d2e6 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
3035845 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
7888da6 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 18, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
a3aaa0e 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 18, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
99b8b6a 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 18, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
a26c37b 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 18, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
ab4c0e8 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 18, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
05c4a0d 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
arielb1 pushed a commit to arielb1/rust that referenced this issue Mar 18, 2017
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
a8b619c 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
arielb1 pushed a commit to arielb1/rust that referenced this issue Mar 19, 2017
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
c1a864d 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 19, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
4bab562 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 19, 2017
@frewsxcv
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
d74c528 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
anatol pushed a commit to anatol/steed that referenced this issue Mar 31, 2017
@frewsxcv
Rollup merge of #40590 - z1mvader:master, r=steveklabnik
fe2c393 
documented order of conversion between u32 an ipv4addr

This fixes rust-lang/rust#40118
@VilleHallivuori VilleHallivuori mentioned this issue Mar 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documented order of conversion between u32 an ipv4addr
3 participants
@steveklabnik @nagisa @sfackler