Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Procedural macros: attributes are not documented #39821

Closed
steveklabnik opened this issue Feb 14, 2017 · 1 comment · Fixed by #39845
Closed

Procedural macros: attributes are not documented #39821

steveklabnik opened this issue Feb 14, 2017 · 1 comment · Fixed by #39845
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@steveklabnik
Copy link
Member 

#[proc_macro_derive(CustomDerive, attributes(custom_attr1, custom_attr2))]
fn custom_derive(...) ...

is not described in https://doc.rust-lang.org/stable/book/procedural-macros.html nor the reference.

I'm happy to mentor anyone who wants to fix this.
@steveklabnik steveklabnik added A-docs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Feb 14, 2017
@JDemler
Copy link
Contributor

JDemler commented Feb 14, 2017

I am happy to write my experience with this issue down.
Will do it either tonight or tomorrow morning.

@JDemler JDemler mentioned this issue Feb 15, 2017
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 24, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39845 - JDemler:master, r=steveklabnik
03e9e00 
Add Documentation for Custom Attributes and Error Reporting in Procedural Macros

This fixes rust-lang#39821 .

I'm not sure if the process of how to access custom attributes should be documented as well.
But I feel, that this should rather be documented in `syn`
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 24, 2017
@frewsxcv
Rollup merge of rust-lang#39845 - JDemler:master, r=steveklabnik
a39632c 
Add Documentation for Custom Attributes and Error Reporting in Procedural Macros

This fixes rust-lang#39821 .

I'm not sure if the process of how to access custom attributes should be documented as well.
But I feel, that this should rather be documented in `syn`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Documentation for Custom Attributes and Error Reporting in Procedural Macros JDemler/rust
2 participants
@steveklabnik @JDemler