Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctests aren't running for documentation of macros #38219

Closed
sgrif opened this issue Dec 7, 2016 · 3 comments
Closed

Doctests aren't running for documentation of macros #38219

sgrif opened this issue Dec 7, 2016 · 3 comments
Assignees
@jseyfried
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.

Comments

@sgrif
Copy link
Contributor

sgrif commented Dec 7, 2016

I noticed that in a branch on Diesel where I had forgotten to update a few doctests, our builds were passing on nightly but failing on stable and beta. It appears that the doctests on macros are not being run on the current nightly. https://travis-ci.org/diesel-rs/diesel/builds/181708974
@bluss bluss added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Dec 7, 2016
@alexcrichton
Copy link
Member

cc @jseyfried, does this ring a bell for you?

@jseyfried jseyfried self-assigned this Dec 8, 2016
@jseyfried jseyfried mentioned this issue Dec 8, 2016
Merged
@jseyfried
Copy link
Contributor

This was caused by #37890, fixed in #38239.

@alexcrichton
Copy link
Member

Thanks for the quick fix @jseyfried!

bors added a commit that referenced this issue Dec 10, 2016
@bors
Auto merge of #38239 - jseyfried:fix_doc_tests_on_macros, r=eddyb
c79d0b4 
Fix doc-tests on exported `macro_rules!`

Fixes #38219.
r? @eddyb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jseyfried jseyfried

Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @sgrif @bluss @jseyfried