Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious failure in HeapFree on Windows #37395

Closed
alexcrichton opened this issue Oct 25, 2016 · 2 comments
Closed

Spurious failure in HeapFree on Windows #37395

alexcrichton opened this issue Oct 25, 2016 · 2 comments
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) O-windows Operating system: Windows

Comments

@alexcrichton
Copy link
Member

https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/2829/steps/test/logs/stdio
https://gist.github.com/alexcrichton/9f36ff87645b87d02a0ee6d302d5798e

doc tests for: C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src/doc\nomicon\repr-rust.md

running 7 tests
test _4 ... ignored
test _6 ... FAILED
test _0 ... ok
test _3 ... ok
test _1 ... ok
test _5 ... ok
test _2 ... ok

failures:

---- _6 stdout ----
    thread '_6' panicked at 'assertion failed: err != 0', C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\liballoc_system\lib.rs:233
note: Run with `RUST_BACKTRACE=1` for a backtrace.
thread '_6' panicked at 'couldn't compile the test', C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\librustdoc\test.rs:283


failures:
    _6

test result: FAILED. 5 passed; 1 failed; 1 ignored; 0 measured

where the relevant line is here:

debug_assert!(err != 0);

This is... terrifying!

@alexcrichton alexcrichton added O-windows Operating system: Windows A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) labels Oct 25, 2016
@retep998
Copy link
Member

I really wish this bug wasn't so spurious, so we could reliably figure out what was causing it. At the very least we need to change that debug_assert! to print out the error itself when that occurs, although I'd prefer changing it to assert! if the cost of doing so is acceptable.

Manishearth added a commit to Manishearth/rust that referenced this issue Oct 26, 2016
…chton

Print out the error when HeapFree failures do occur

cc rust-lang#37395

I'd prefer to use `assert!` instead of `debug_assert!` if the cost is acceptable.

r? @alexcrichton
bors added a commit that referenced this issue Oct 30, 2016
Print out the error when HeapFree failures do occur

cc #37395

I'd prefer to use `assert!` instead of `debug_assert!` if the cost is acceptable.

r? @alexcrichton
@alexcrichton
Copy link
Member Author

We haven't seen this in nearly a year, so this isn't doing much help staying open, so I'm going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

2 participants