Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try!() macro is generating the unused_qualifications lint #37345

Closed
bluss opened this issue Oct 22, 2016 · 5 comments · Fixed by #37361
Closed

try!() macro is generating the unused_qualifications lint #37345

bluss opened this issue Oct 22, 2016 · 5 comments · Fixed by #37361
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bluss
Copy link
Member

bluss commented Oct 22, 2016

The macro should not cause warnings in the user's code. This seems to show up due to other changes.

Seen here: https://internals.rust-lang.org/t/regression-report-stable-2016-10-20-vs-nightly-2016-10-21/4255

The lint is allow by default, but some configurations will enable it.
@bluss
Copy link
Member Author

bluss commented Oct 22, 2016

I don't think adding an allow in try!() is the right fix. Using explicit qualifications is the right thing to do in every macro, and we don't want every user-defined macro to have to add the allow attribute.

@jseyfried Do you know anything about this?

@jseyfried
Copy link
Contributor

I'm not aware of any recent changes that would cause new warnings / regressions, but I could disable the lint for macro-expanded paths easily.

TheNeikos added a commit to TheNeikos/rustbreak that referenced this issue Oct 22, 2016
@TheNeikos
Remove unusued qualifications lint
d39a369 
This is due to rust-lang/rust#37345, once that is fixed this can be
reverted
@TimNN
Copy link
Contributor

TimNN commented Oct 22, 2016

Introduced between nightly-2016-10-19 and nightly-2016-10-21 (Changes).

@jseyfried: This could probably be a side effect of #37213.

@TimNN TimNN added A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. A-compiler T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed A-compiler labels Oct 22, 2016
TheNeikos added a commit to TheNeikos/rustbreak that referenced this issue Oct 22, 2016
@TheNeikos
Remove unusued qualifications lint
413f13d 
This is due to rust-lang/rust#37345, once that is fixed this can be
reverted
@jseyfried jseyfried mentioned this issue Oct 23, 2016
Merged
@jseyfried
Copy link
Contributor

@TimNN Indeed, fixed in #37361.

bors added a commit that referenced this issue Oct 26, 2016
@bors
Auto merge of #37361 - jseyfried:fix_crate_var_regressions, r=nrc
a7557e7 
Fix `$crate`-related regressions

Fixes #37345, fixes #37357, fixes #37352, and improves the `unused_extern_crates` lint.
r? @nrc
@retep998
Copy link
Member

Totally just got bitten by this in winapi, can't wait for the next nightly.

@Centril Centril mentioned this issue Aug 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix $crate-related regressions jseyfried/rust
4 participants
@retep998 @TimNN @bluss @jseyfried