Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXME: Drop glue takes unsized values differently than other functions #36457

Closed
nikomatsakis opened this issue Sep 13, 2016 · 1 comment
Closed

FIXME: Drop glue takes unsized values differently than other functions #36457

nikomatsakis opened this issue Sep 13, 2016 · 1 comment

Comments

@nikomatsakis
Copy link
Contributor

Currently drop glue takes sized values as a *(data, meta), but elsewhere in MIR we pass (data, meta) as two separate arguments. This is hokey and introduces a lot of pain to convert back and forth. I've tried to tag many of those areas with this issue number.

cc @eddyb
@Mark-Simulacrum
Copy link
Member

I have a branch that in theory fixes this, but it's based on #38302. Will post PR once that gets merged.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Dec 21, 2016
Merged
bors added a commit that referenced this issue Dec 23, 2016
@bors
Auto merge of #38511 - Mark-Simulacrum:drop-glue, r=eddyb
ce4461f 
Make drop glue for unsized value pass two arguments instead of *(data, meta)

Fixes #36457

r? @eddyb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikomatsakis @Mark-Simulacrum