Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rustbuild] should not assume llvm-config shares root with FileCheck #36282

Closed
nagisa opened this issue Sep 5, 2016 · 2 comments
Closed

[rustbuild] should not assume llvm-config shares root with FileCheck #36282

nagisa opened this issue Sep 5, 2016 · 2 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@nagisa
Copy link
Member

nagisa commented Sep 5, 2016

I have a wrapper for llvm-config in ~/local/bin/ to workaround for a bug in original llvm-config, but rustbuild assumes there’s FileCheck in the same directory as llvm-config, making rustbuild fail.

It should instead get the LLVM bindir from llvm-config itself.

$ which llvm-config
/home/nagisa/local/bin/llvm-config
$ llvm-config --bindir
/usr/bin
@sanxiyn sanxiyn added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 5, 2016
@durka
Copy link
Contributor

durka commented Sep 5, 2016

We also just added a config.toml option to stop it from looking for FileCheck at all.

@sanxiyn
Copy link
Member

sanxiyn commented Dec 20, 2016

Another way to trigger this is llvm-config = "/usr/bin/llvm-config-3.9". bindir is /usr/lib/llvm-3.9/bin, /usr/bin/FileCheck-3.9 is a symbolic link to /usr/lib/llvm-3.9/bin/FileCheck. rustbuild tries to find /usr/bin/FileCheck which does not exist and fail.

alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 20, 2016
Find FileCheck using llvm-config

This allows using system LLVM from Debian package to run codegen tests.

Fix rust-lang#36282.

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants