Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0220 needs to be updated to new format #35385

Closed
sophiajt opened this issue Aug 5, 2016 · 2 comments
Closed

E0220 needs to be updated to new format #35385

sophiajt opened this issue Aug 5, 2016 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

From: src/test/compile-fail/E0220.rs

Error E0220 needs a span_label, updating it from:

error[E0220]: associated type `F` not found for `Trait`
  --> src/test/compile-fail/E0220.rs:15:18
   |
15 | type Foo = Trait<F=i32>; //~ ERROR E0220
   |                  ^^^^^

To:

error[E0220]: associated type `F` not found for `Trait`
  --> src/test/compile-fail/E0220.rs:15:18
   |
15 | type Foo = Trait<F=i32>; //~ ERROR E0220
   |                  ^^^^^ associated `F` not found in `Trait`
@sophiajt sophiajt added A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 5, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Update E0220 message to new format

Part of rust-lang#35233 .
Fixes rust-lang#35385.

r? @jonathandturner

Should it keep E0191?
@chamoysvoice
Copy link
Contributor

Requirements changed a little bit, instead of

associated F not found in Trait

a more semantic and still short phrase is:

associated type F not found

NOTE: the full error label is still included on the top part aside to E0220

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 13, 2016
Update E0220 message to new format

Part of rust-lang#35233 .
Fixes rust-lang#35385.

r? @jonathandturner

Should it keep E0191?
eddyb added a commit to eddyb/rust that referenced this issue Aug 14, 2016
Update E0220 message to new format

Part of rust-lang#35233 .
Fixes rust-lang#35385.

r? @jonathandturner

Should it keep E0191?
@sophiajt
Copy link
Contributor Author

@chamoysvoice - looks like you need to update some of the unit tests so this can pass:

error: 2 unexpected errors found, 1 expected errors not found

error: /build/src/test/compile-fail/E0220.rs:15: unexpected "error": '15:12: 15:24: the value of the associated type `Bar` (from the trait `Trait`) must be specified [E0191]'

error: /build/src/test/compile-fail/E0220.rs:15: unexpected "note": 'missing associated type `Bar` value'

error: /build/src/test/compile-fail/E0220.rs:16: expected error not found: E0191

error: /build/src/test/compile-fail/unboxed-closure-sugar-wrong-trait.rs:15: unexpected "note": 'associated type `Output` not found'

error: 1 unexpected errors found, 0 expected errors not found
failures:

    [compile-fail] compile-fail/E0220.rs

    [compile-fail] compile-fail/unboxed-closure-sugar-wrong-trait.rs

You can run the full compile-fail test suite to make sure the changes worked using:

python src/bootstrap/bootstrap.py --step check-cfail --stage 1

bors added a commit that referenced this issue Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants