Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0055 needs to be updated to new format #35213

Closed
sophiajt opened this issue Aug 2, 2016 · 3 comments
Closed

E0055 needs to be updated to new format #35213

sophiajt opened this issue Aug 2, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016 •
edited
Loading

From: src/test/compile-fail/E0055.rs

Error E0055 needs a span_label, updating it from:

error[E0055]: reached the recursion limit while auto-dereferencing Foo
  --> src/test/compile-fail/E0055.rs:21:13
   |
21 |     ref_foo.foo(); //~ ERROR E0055
   |             ^^^

To:

error[E0055]: reached the recursion limit while auto-dereferencing Foo
  --> src/test/compile-fail/E0055.rs:21:13
   |
21 |     ref_foo.foo(); //~ ERROR E0055
   |             ^^^ deref recursion limit reached

Bonus: there may be a better wording for the label. Suggestions welcome!
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 3, 2016
Closed
@nickmass
Copy link
Contributor

nickmass commented Aug 3, 2016

I will take this issue.

@nickmass nickmass mentioned this issue Aug 4, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
@GuillaumeGomez
Rollup merge of rust-lang#35333 - nickmass:e0055-formatting, r=jonath…
854532a 
…andturner

Update compiler error E0055 to use new error format

Addresses rust-lang#35213, Part of the rust-lang#35233 meta bug

r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
@GuillaumeGomez
Rollup merge of rust-lang#35333 - nickmass:e0055-formatting, r=jonath…
0339904 
…andturner

Update compiler error E0055 to use new error format

Addresses rust-lang#35213, Part of the rust-lang#35233 meta bug

r? @jonathandturner
@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

The bonus for this issue hasn't been attempted yet.

@sophiajt
Copy link
Contributor Author

@KiChjang - closing this, but you like you can definitely file an issue for the bonus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sophiajt @nickmass @KiChjang